1162732 - Multiparty call test case 15.7.1: “speaker” and “mute” options on phone UI are disabled when multi party call is in active state

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[pgravel]

Test Procedure:
1. Dial first call
2. Network accepts call and Call is in active state
   OK >>> After this step, user can toggle “speaker” and “mute” options on phone UI. It just works fine.
3. Place first call on hold
   OK >>> After this step, “speaker” and “mute” are disabled, as expected
4. Dial second call
   KO >>> After this step, “speaker” and “mute” options on phone UI are still disabled.
5. Merge/join both calls to make it conference call
6. Both calls are in conference and active state
   KO >>> After this step, “speaker” and “mute” options on phone UI are still disabled.

Alternative scenario that also reproduces the issue:
1. Dial first call
2. Network accepts call and Call is in active state
   OK >>> After this step, user can toggle “speaker” and “mute” options on phone UI. It just works fine.
3. Place first call on hold
   OK >>> After this step, “speaker” and “mute” are disabled, as expected
4. Dial second call
   KO >>> After this step, “speaker” and “mute” options on phone UI are still disabled.
5. Disconnect 2nd call
   KO >>> After this step, “speaker” and “mute” options on phone UI are still disabled.


In both cases the buttons can be re-enabled by holding the active call again and then resuming it.
It looks like the UI simply doesn't transition out of the held state when a second call is made.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Would like to know if it happens on 2.0, 2.1 as well.

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue occurs on Flame 3.0 and 2.2.

Actual results: Putting a call on hold will disable certain buttons that do not get renabled when dialing a different number or combining those calls into a conferencce..
	
Environmental Variables:
Device: Flame 3.0
BuildID: 20150508103602
Gaia: 3692ad2cf3a047cc66f58f655a56b6ec559ef253
Gecko: cef2b76b082d
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150507215856
Gaia: 88d3ac2721a5484495c2ed60e4a068945f0de5aa
Gecko: 8ad16ebe659d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

This issue cannot occur on 2.1 or earlier since there was no hold function in the dialer and is thus NOT considered a regression.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150507084645
Gaia: 3e7bd686ecd852f4dfa4605b45f558e6bd34f02a
Gecko: d85173eb5bf4
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Johan Lorenzo [:jlorenzo]]

(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #1)
> Would like to know if it happens on 2.0, 2.1 as well.

Question answered by Jayme in comment 2.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Certification blocker on a feature which has been introduced in 2.2.

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

soft reminder to module owner :)

Comment 6

[Gabriele Svelto [:gsvelto]]

I'm currently working on this, I couldn't reproduce it sooner because of bug 1164472 which I had to bisect first (and that was a bit of a lengthy process).

Comment 7

[Gabriele Svelto [:gsvelto]]

BTW this is one of the many instances of bug 1082588 so blocking it.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1162732-speaker-and-mute-button-status > mozilla-b2g:master

Comment 9

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8605768 [details] [review]
[gaia] gabrielesvelto:bug-1162732-speaker-and-mute-button-status > mozilla-b2g:master

The fix was fairly straightforward: I've moved the logic that handles the speaker/mute buttons from the hold/resume action to the oncallschanged/onstatechanged handlers so now the buttons will always correctly reflect the state of the calls. I've modified unit-tests accordingly.

This whole code is somewhat messy and I plan on refactoring it soon.

Note that I've re-intendented a block of code which was out of place in updateMergeAndOnHoldStatus() together with the other changes.

Comment 10

[Tamara Hills [:thills]]

Comment on attachment 8605768 [details] [review]
[gaia] gabrielesvelto:bug-1162732-speaker-and-mute-button-status > mozilla-b2g:master

Hi Gabriele,

It looks good and worked fine for me.

Thanks,
-tamara

Comment 11

[Gabriele Svelto [:gsvelto]]

Thanks Tamara, time to land.

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/23b3a165ce3bc4fc5e0ef63b8ad45c63ce636723

Comment 13

[Anshul]

Comment on attachment 8605768 [details] [review]
[gaia] gabrielesvelto:bug-1162732-speaker-and-mute-button-status > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.2 uplift.

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1162732-v2.2-uplift > mozilla-b2g:v2.2

Comment 16

[Gabriele Svelto [:gsvelto]]

Here's a PR with the pack cherry-picked and properly uplifted for v2.2.

Comment 17

[Gabriele Svelto [:gsvelto]]

Here's a PR with the patch cherry-picked and properly uplifted for v2.2.

Comment 18

[Gabriele Svelto [:gsvelto]]

The try run is green, merged to gaia/v2.2 63e9eeec3032318f8a240f80b6a184fa4b50b6e1

https://github.com/mozilla-b2g/gaia/commit/63e9eeec3032318f8a240f80b6a184fa4b50b6e1

Comment 20

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v2.2&3.0 by the STR in Comment 0.

Actual results: User can enable and disable the mute and speaker anytime in the second call or in a conference.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5


Device: Flame v2.2 build(Pass)
Build ID               20150528002504
Gaia Revision          999bc627063d16c20f703e702f31a5cf0da8b4a6
Gaia Date              2015-05-28 02:16:40
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/351101ec82ba
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150528.034806
Firmware Date          Thu May 28 03:48:15 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Pass)
Build ID               20150528160205
Gaia Revision          e7d268074ee3c9eeb191c2205c0e35992fb3915d
Gaia Date              2015-05-28 10:47:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f986e55c4e0b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150528.192335
Firmware Date          Thu May 28 19:23:44 EDT 2015
Bootloader             L1TC000118D0

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 22

[Shally Li（leave from Mozilla）]

Note:
It can't merge both calls to make it conference call on Flame v2.2 as mentioned in step 5 of Comment 0.