1163945 - Crash [@ _ZThn8_N7mozilla3dom7workers24serviceWorkerScriptCache12_GLOBAL__N_114CompareNetwork14OnStartRequestEP10nsIRequestP11nsISupports ]

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Robin Whittleton]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150511122605

Steps to reproduce:

Not reproducible unfortunately. I left my computer alone for a standup with my usual set of tabs (couple of GMails, Google Calendar, some Github repos etc) and when I came back it had crashed.


Actual results:

Bang: https://crash-stats.mozilla.com/report/index/4d28e709-418c-45ab-8076-8ec7a2150512


Expected results:

No bang.

I wouldn’t normally have bothered filing, but the crash signature looked pretty strange and the 8 other reports ( https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=3&signature=_ZThn8_N7mozilla3dom7workers24serviceWorkerScriptCache12_GLOBAL__N_114CompareNetwork14OnStartRequestEP10nsIRequestP11nsISupports ) have all happened in the last 3 days so presumably it’s something recent. The signature makes it look like a service worker issue, but feel free to move if it’s not.

Comment 1

[Robin Whittleton]

Possible dupe of #1163404 and #1163593 ?

Comment 2

[Robin Whittleton]

Bug #1163403 and bug #1163593 even.

Comment 5

[(no longer active)]

I tried to find a way to reproduce this so that I can write a test case for it, so far without success.  But this is clearly happening because we're aborting the CompareNetwork object, and not handling that properly in OnStartRequest.

Comment 6

[(no longer active)]

Attachment: Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst

Comment 7

[u279076]

Marking this as NEW based on comment 5.

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8605474 [details] [diff] [review]
Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst

Review of attachment 8605474 [details] [diff] [review]:
-----------------------------------------------------------------

preemptive r+ :)

Comment 10

[Robert Kaiser]

[Tracking Requested - why for this release]:
This is one of the top 10 crashes we have with people still on builds of 40, so I expect it to be there in Dev Edition as well (unless it's specific to e10s).

Comment 11

[Sören Hentzschel]

It's not specific to e10s, I had the same crash with 41 Nightly and e10s disabled yesterday.

Comment 12

[(no longer active)]

Yeah, this is unrelated to e10s.

Comment 13

[(no longer active)]

Comment on attachment 8605474 [details] [diff] [review]
Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst

(marking as r+ as per comment 8!)

Comment 14

[(no longer active)]

Comment on attachment 8605474 [details] [diff] [review]
Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst

Approval Request Comment
[Feature/regressing bug #]: Bug 1159378
[User impact if declined]: This is a topcrasher on Nightly.
[Describe test coverage new/current, TreeHerder]: None, I couldn't come up with an easy way to test this.
[Risks and why]: Very low risk, just adding a null check.
[String/UUID change made/needed]: none

Comment 15

[jen strickland :jenstrickland]

Since this is a crash, and a regression, enabled tracking for 40 and 41.

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8605474 [details] [diff] [review]
Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst

Safe fix. Let's put this directly on Aurora to address the crash before we re-enable updates.

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3913a94d7f25

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3913a94d7f25

Comment 19

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #16)
> Comment on attachment 8605474 [details] [diff] [review]
> Handle aborted CompareNetwork jobs properly in CompareNetwork::OnStartRequst
> 
> Safe fix. Let's put this directly on Aurora to address the crash before we
> re-enable updates.

Awesome, just ran into this on Aurora 41. :)

Comment 20

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72b2c07a0e84

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Jeff, did you run into this crash in Aurora FF41? Can you please re-open the bug if that is the case?

Comment 22

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Ritu Kothari (:ritu) from comment #21)
> Jeff, did you run into this crash in Aurora FF41? Can you please re-open the
> bug if that is the case?

Not so far, but I will re-open if I see it.