1164287 - Remove build icon in Settings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

At first I thought it provided a nice context after the updates from inheriting the L theme, but it looks rather redundant now and seems to take away space from the top header label (especially considering localization).

Let's remove that icon from the top.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I previously did some work on the build icon size in bug 1132751 - investigate which parts of this should change or be removed.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, is this only for Android L?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #2)
> Anthony, is this only for Android L?

I'm open to carrying out this decision to users on other versions too. I know we decided to keep it around but originally, but it does seem awfully unnecessary after giving it some time. :)

NI-ing Sebastian here since he brought it up in the other thread

Sebastian, I'd say we can go ahead with this!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: up_button_on_android4.png

Afaik we will still need to show the icon on Android 4.x devices (and maybe Honeycomb?) because the up button will be part of the app icon (see attached screenshot). Without that we would end up with a tiny up indicator that is almost impossible to hit. At least as long as we do not need some compatibility library (e.g. ActionBarCompat) that backports all the new stuff.

Nevertheless we should be good to go on Android 5+. On 2.3 there's no ActionBar at all, so no problem there.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Yeah, that's true and that's fine too. I forgot about that icon, heh.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

This icon needs to go.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: material-actionbar.png

I did not only remove the icon but changed the v21+ theme of settings and the sync activity to use the Material ActionBar style. What do you think?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Yes, please.

Comment 10

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8644982 [details]
material-actionbar.png

LIKE.

Does this affect the action bar for text selection on web pages? 

I think this is great, moving in the Material direction! but how will this inconsistency feel? 

Can I see a build with this Sebastian?

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #10)
> Does this affect the action bar for text selection on web pages? 

No, I just changed it for settings and sync status to avoid breaking all kinds of things.

> I think this is great, moving in the Material direction! but how will this
> inconsistency feel? 

So this will only affect Android 5+ devices, so for them it should be more consistent now. Do we have any other ActionBars to fix? Right now I don't know of any but there probably are some.

> Can I see a build with this Sebastian?

Sure! I'll ping you on IRC.

Comment 12

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

saw it. tried it. love it. SHIP IT!

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1164287-settings-actionbar.patch

Comment 14

[Martyn Haigh (:mhaigh)]

Comment on attachment 8645190 [details] [diff] [review]
1164287-settings-actionbar.patch

Review of attachment 8645190 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome

Comment 15

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/f936a8642a500702d7e61da0a4ba8a9153b741af
changeset:  f936a8642a500702d7e61da0a4ba8a9153b741af
user:       Sebastian Kaspari <[e-mail]>
date:       Tue Aug 11 10:39:56 2015 +0200
description:
Bug 1164287 - Theme v21: Base ActionBar.FxAccountStatusActivity and ActionBar.GeckoPreferences on Material ActionBar. r=mhaigh

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f936a8642a50