1164494 - Only automatically review/sign an unlisted addon after step 3 is done

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathieu Agopian [:magopian]]

Even if the unlisted addon passes validation, it shouldn't be reviewed/signed before all the needed information (on step 3) are provided.

At the moment, it's done in the submit step 2 (https://github.com/mozilla/olympia/blob/641c73776613bf27838ac1dcc8e5fb2cbb0bc71d/apps/devhub/views.py#L1393)

Comment 1

[Mathieu Agopian [:magopian]]

I'm going to wontfix this one for the following reasons:
1/ by default, the name and summary are taken from the install.rdf, even if they're not manually added/modified during the submission process
2/ the add-on can't be downloaded before all the steps are completed: when going to the devhub page, we're automatically redirected to the submit step 3 if it wasn't completed.

Comment 2

[Mathieu Agopian [:magopian]]

I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1167185 to make sure that an unlisted addon that hasn't completed step 3 is still seen as incomplete in the devhub.