Closed Bug 1164593 Opened 9 years ago Closed 9 years ago

Import file UI has a title "Save profile..."

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set
normal

Tracking

(firefox40 verified, firefox41 fixed)

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- verified
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

Should be "Import recording..." -- and we should probably save the save prompt to be "Save recording..." as well.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8607179 - Flags: review?(vporof)
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch

Review of attachment 8607179 [details] [diff] [review]:
-----------------------------------------------------------------

Why not localize now?
Attachment #8607179 - Flags: review?(vporof) → review+
Localized patches can't make it to 40.1, so the localization is being tracked in the bug mentioned, if we decide to localize it (some discussions on what we need to localize from last meeting)
https://hg.mozilla.org/mozilla-central/rev/820337cf32eb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Flags: qe-verify+
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8607179 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch

Change approved to skip one train as part of the spring campaign.
Attachment #8607179 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x46) and Mac OS X 10.9.5.

The save profile prompt dialog has the title "Save recording..." while the import profile prompt dialog shows "Import recording..." as a title.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.