1164608 - Hook android/desktop-in-TC builds up to try

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I have some notes on how to do this in
  https://gist.github.com/djmitche/9ca81f91798d512d543d#file-80_try_jobs-txt

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I had success in getting the job to run:
  http://docs.taskcluster.net/tools/task-inspector/#aJ8e8WvFTkS7D6OWlkVByQ/0
but I'm not communicating the desired repo and config to mozharness.  I need to read a bit more mozharness to figure out how that should work.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: bz://1164608/dustin

/r/9073 - Bug 1164608: enable Android builds from try; r=mrrrgn

Pull down this commit:

hg pull -r d7fefdf3fafb2d44e4ecaf096bd060a6ecb67a73 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

You are a boss. :+1

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9073/#review7745

:garndt, do you mind having a look too?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

/r/9073 - Bug 1164608: enable Android builds from try; r=mrrrgn
/r/9105 - Bug 1164608: remove incorrect comment; r=garndt

Pull down these commits:

hg pull -r a6aebfe0706274282c3e713f187c921dcd616515 https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

/r/9073 - Bug 1164608: enable Android builds from try; r=mrrrgn
/r/9107 - Bug 1164608: remove incorrect comment; r=garndt

Pull down these commits:

hg pull -r a6aebfe0706274282c3e713f187c921dcd616515 https://reviewboard-hg.mozilla.org/gecko/

Comment 7

[Greg Arndt [:garndt]]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

https://reviewboard.mozilla.org/r/9071/#review7773

::: testing/taskcluster/tasks/branches/try/job_flags.yml:103
(Diff revision 2)
> +  android64-api11:

I think we've been duplicating this flage in branches/base_job_flags.yml to have a list of all available flags that might be used.

::: testing/taskcluster/tasks/builds/android_64_api_11.yml:11
(Diff revision 2)
> +  workerType: b2g-desktop-opt

If you find that this is competing too much with the workload of the b2g desktop builds, we could build out a workertype for android.  Might also help with the caches that are stored on the worker since they will not be shared between b2g and android builds.

::: testing/taskcluster/tasks/builds/android_64_api_11.yml:14
(Diff revision 2)
> +    - 'index.buildbot.branches.{{project}}.linux64-android'

I'm not sure what the consensus is yet, but I believe there is a discussion about unifying the route namespaces between what we're doing for other TC tasks and those that are index.buildbot

Comment 8

[Greg Arndt [:garndt]]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

https://reviewboard.mozilla.org/r/9071/#review7775

Ship It!

Comment 9

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/9071/#review7827

::: testing/taskcluster/tasks/builds/android_64_api_11.yml:53
(Diff revision 2)
> +      groupSymbol: "AnTC"

As discussed on IRC, if these are to appear along side the buildbot jobs for now, groupSymbol could be changed to 'tc' and then add Symbol: B.  This should make it appear in the same row as tc(B)

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

From irc discussion:
 - we can easily change the workerType later, so I'll leave it for nwo
 - once this is in-tree it can follow the crowd regarding index namespaces

I got irc feedback on
 - the symbol and group symbol (above)
 - the try flag -- I'll use what Buildbot uses, android-api-11
 - the task name, machine.platform, description, etc (still working on this)
 - hiding the job in treeherder -- sheriffs will do this and I'll file a bug to unhide

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

/r/9073 - Bug 1164608: enable Android builds from try; r=mrrrgn

Pull down this commit:

hg pull -r 8065728a738f113cfba4abba13ddfc985a15f70e https://reviewboard-hg.mozilla.org/gecko/

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9071/#review7831

> As discussed on IRC, if these are to appear along side the buildbot jobs for now, groupSymbol could be changed to 'tc' and then add Symbol: B.  This should make it appear in the same row as tc(B)

..and these are the default values from the inherited build.yml

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

/r/9073 - Bug 1164608: enable Android builds from try; r=mrrrgn

Pull down this commit:

hg pull -r 8065728a738f113cfba4abba13ddfc985a15f70e https://reviewboard-hg.mozilla.org/gecko/

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9071/#review7833

Aside from what's discussed in the bug, I added a REGISTRY file pointing to my quay.io repo, since I don't have permission to upload to the mozilla repo.

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

Here's what it looks like in try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f4618080fa1

The failure is because bug 1166380 isn't landed yet, but it's just as well -- saving time doing useless runs that would fail anyway (due to the lack of a relengapi token).

Comment 16

[Greg Arndt [:garndt]]

Comment on attachment 8607757 [details]
MozReview Request: bz://1164608/dustin

https://reviewboard.mozilla.org/r/9071/#review7845

Ship It!

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86b9d8148ee9

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86b9d8148ee9

Comment 20

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1164608: enable Android builds from try; r=mrrrgn

Comment 21

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1164608: remove incorrect comment; r=garndt