1164812 - mach mercurial-setup handling of reviewboard doesn't mark the version-control-tools repo as needing update

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Ed Morley [:emorley]]

In mach mercurial-setup, when calling prompt_external_extension(), you can either:
* not pass in a path - in which case the version-control-tools/hgext/<extension-name>/ is used, and the version-control-tools repo marked as needing a clone/update
* pass your own path - in which case the version-control-tools repo isn't cloned/updated

The intention for the second case, was for extensions that do not live in the version control tools repo, so would have their own repo cloned/updated separately.

However for reviewboard, since we have to use client.py specifically (rather than version-control-tools/hgext/reviewboard/*), the call to prompt_external_extension() has been made with the path set.

This means that if the reviewboard extension was the only one the user chose to accept when prompted, we won't clone (or update if already cloned) the version-control-tools repo.

Options:
1) Remove external extension support entirely (once bug 978514 lands there will be no external extensions referenced by mach mercurial setup):
  * rename prompt_external_extension()  to prompt_vct_extension()
  * make 'path' relative to version-control-tools repo root
  * set self.update_vcs_tools to true regardless of the value of path
2) Leave external extension support in, but set self.update_vcs_tools to true in prompt_external_extension(), regardless of the value of path

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/file/5f661a622c57/tools/mercurial/hgsetup/wizard.py#l272
https://hg.mozilla.org/integration/mozilla-inbound/file/5f661a622c57/tools/mercurial/hgsetup/wizard.py#l420

Comment 2

[Gregory Szorc [:gps]]

I'd like to leave external extension support in because there are a number of Facebook extensions that should arguably be in mach mercurial-setup.

It's a good idea for v-c-t to always be up to date. We should just do the update unconditionally.

Comment 3

[Ed Morley [:emorley]]

Attachment: mach mercurial-setup: Always mark the v-c-t repo as needing update

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa8ad4978b15

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa8ad4978b15