1164864 - App abuse report can be sent with blank comment

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: report submitted.png

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36

Steps to reproduce:

1. Go to https://marketplace-dev.allizom.org/app/delicious-sushi-12
2. Click on "Report Abuse" button
3. Give some space in the input section
4. Notice the button "submit report" has lightend up


Actual results:

The blank report can be sent by clicking button "submit report" 



Expected results:

The blank report should not be sent by clicking button "submit report"

Comment 1

[Kevin Ngo [:ngoke]]

Good bug :)

Comment 2

[Bharath Thiruveedula[:tbharath]]

can I work on this?

Comment 3

[Atique Ahmed Ziad [:atiqueahmedziad]]

Sure work on it :)

Comment 4

[simplyblue24]

Attachment: Patch for the bug,which sends an empty report

Pull request:https://github.com/mozilla/fireplace/pull/1225

Comment 5

[Jaipal Singh]

Attachment: A patch to prefent empty form submissions

Found a bug that prevents empty form submissions. Fixed it.

Comment 6

[Atique Ahmed Ziad [:atiqueahmedziad]]

Are you still working on this ?

Comment 7

[Atique Ahmed Ziad [:atiqueahmedziad]]

Unassigned due to inactivity. For the next patch, make the submit button disabled until there is any text in the text box. So, the submit button will remain disabled if users gives blank spaces. 
Take this bug & work on it :)

Comment 8

[Yateesh Yadav]

I would like to work on this bug.

Comment 9

[Ram Dayal Vaishnav [:ram]]

Sure Yateesh. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.

Comment 10

[Yateesh Yadav]

To achieve goal of keeping the button disabled till we press non- spacial characters I tried approach of 
checking the string before the toggle Submit Form action state. But it didn't work can you please advice.
  
abuse.js: while(data.trim()==null){ 
          forms.toggleSubmitFormState($this,false);}

Comment 11

[Ram Dayal Vaishnav [:ram]]

Kevin, could you please advice on above?

Comment 12

[Shubham Gupta]

I would like to work on this bug.

Comment 13

[Ram Dayal Vaishnav [:ram]]

Shubham, Yateesh is already working on this bug.

Comment 14

[Ram Dayal Vaishnav [:ram]]

NI'ing David also for comment#10

Comment 15

[David Durst [:ddurst]]

Kevin would do a much better job of advising on this than I would. That said, referencing code even in a commit or a PR is going to be faster than a general mention of approach.

Comment 16

[David Durst [:ddurst]]

Any progress on this? If this is still unchanged in two weeks, we'll unassign it.

Comment 17

[Atique Ahmed Ziad [:atiqueahmedziad]]

Unassigned due to inactivity

Comment 18

[Vince Tieu [:vtieu]]

This bug seems to be related to #1164857

PR: https://github.com/mozilla/marketplace-core-modules/pull/53

Comment 19

[Atique Ahmed Ziad [:atiqueahmedziad]]

Vince, thanks for the pr 
assigning you!

Comment 20

[Atique Ahmed Ziad [:atiqueahmedziad]]

Happy to consider the bug as fixed. Thanks Vince!
Fixed in https://github.com/mozilla/marketplace-core-modules/compare/9f0462fa...8b015ff3