Closed Bug 1164864 Opened 6 years ago Closed 5 years ago

App abuse report can be sent with blank comment

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Avenir
defect

Tracking

(Not tracked)

RESOLVED FIXED
2015-05-26

People

(Reporter: atiqueahmedziad, Assigned: vtieu, Mentored)

Details

(Whiteboard: [good first bug])

Attachments

(3 files)

Attached image report submitted.png
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36

Steps to reproduce:

1. Go to https://marketplace-dev.allizom.org/app/delicious-sushi-12
2. Click on "Report Abuse" button
3. Give some space in the input section
4. Notice the button "submit report" has lightend up


Actual results:

The blank report can be sent by clicking button "submit report" 



Expected results:

The blank report should not be sent by clicking button "submit report"
Component: General → Consumer Pages
OS: Unspecified → Windows 7
Hardware: Unspecified → x86
Version: 2.0 → Avenir
OS: Windows 7 → All
Hardware: x86 → All
Good bug :)
Whiteboard: [good first bug]
can I work on this?
Sure work on it :)
Assignee: nobody → jpsinghgoud
Found a bug that prevents empty form submissions. Fixed it.
Priority: -- → P4
Target Milestone: --- → 2015-05-26
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Are you still working on this ?
Flags: needinfo?(jpsinghgoud)
See Also: → 1174350
See Also: 1174350
Unassigned due to inactivity. For the next patch, make the submit button disabled until there is any text in the text box. So, the submit button will remain disabled if users gives blank spaces. 
Take this bug & work on it :)
Assignee: jpsinghgoud → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jpsinghgoud)
Mentor: vaishnav.rd
I would like to work on this bug.
Sure Yateesh. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.
Assignee: nobody → yatee15
Status: NEW → ASSIGNED
To achieve goal of keeping the button disabled till we press non- spacial characters I tried approach of 
checking the string before the toggle Submit Form action state. But it didn't work can you please advice.
  
abuse.js: while(data.trim()==null){ 
          forms.toggleSubmitFormState($this,false);}
Kevin, could you please advice on above?
Flags: needinfo?(kngo)
I would like to work on this bug.
Shubham, Yateesh is already working on this bug.
NI'ing David also for comment#10
Flags: needinfo?(ddurst)
Kevin would do a much better job of advising on this than I would. That said, referencing code even in a commit or a PR is going to be faster than a general mention of approach.
Flags: needinfo?(ddurst)
Any progress on this? If this is still unchanged in two weeks, we'll unassign it.
Flags: needinfo?(kngo) → needinfo?(yatee15)
Unassigned due to inactivity
Assignee: yatee15 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(yatee15)
This bug seems to be related to #1164857

PR: https://github.com/mozilla/marketplace-core-modules/pull/53
Vince, thanks for the pr 
assigning you!
Assignee: nobody → vtieu7
Status: NEW → ASSIGNED
Happy to consider the bug as fixed. Thanks Vince!
Fixed in https://github.com/mozilla/marketplace-core-modules/compare/9f0462fa...8b015ff3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.