Hi-res search icons for localized search plugins

REOPENED
Unassigned

Status

()

defect
REOPENED
4 years ago
11 months ago

People

(Reporter: bnicholson, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
Bug 1157922 added hi-res icons for the en-US locale, but all of the other locales still use 32x32 icons. Assuming search engines don't use different icons across different locales, we could write a script that goes through and updates them. But we'll still need new hi-res icons from UX for any engines that aren't in the en-US locale.

Also, this bug probably isn't iOS specific as we've updated the Android search icons too, so it seems like we should land these new icons directly in the l10n repos. flod, any thoughts?
Flags: needinfo?(francesco.lodolo)
(In reply to Brian Nicholson (:bnicholson) from comment #0)
> Bug 1157922 added hi-res icons for the en-US locale, but all of the other
> locales still use 32x32 icons. Assuming search engines don't use different
> icons across different locales, we could write a script that goes through
> and updates them. But we'll still need new hi-res icons from UX for any
> engines that aren't in the en-US locale.
> 
> Also, this bug probably isn't iOS specific as we've updated the Android
> search icons too, so it seems like we should land these new icons directly
> in the l10n repos. flod, any thoughts?

Unfortunately that is something that requires months, and manual work from me over 70 repositories.
We might even fail to get higher resolution icons for some search engines.

I think the solution here is simply to know that a lot of searchengines will have 32px icons, and adapt the layout.

Side note: bug 1157922 added high-res icons on iOS, they're still 32px in Fennec even for en-US.
Flags: needinfo?(francesco.lodolo)
(Reporter)

Comment 2

4 years ago
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #1)
> I think the solution here is simply to know that a lot of searchengines will
> have 32px icons, and adapt the layout.

Definitely -- I wasn't proposing this as the fix to bug 1164828, but as an orthogonal change. We're updating en-US icons to look better, so I expect that we'd want other locales to look better, too.

> Side note: bug 1157922 added high-res icons on iOS, they're still 32px in
> Fennec even for en-US.

Yeah, but this is changing soon in bug 1156917.
(Reporter)

Updated

4 years ago
See Also: → 1158405
(Reporter)

Comment 3

4 years ago
In the meantime, maybe a good short-term solution for iOS would be to update these plugins ourselves, which we can do since they're included directly in the firefox-ios repo.
(In reply to Brian Nicholson (:bnicholson) from comment #3)
> In the meantime, maybe a good short-term solution for iOS would be to update
> these plugins ourselves, which we can do since they're included directly in
> the firefox-ios repo.

I don't think you can. You might be able to fix some of them, but you will still have searchplugins with smaller icons because they're not shipping in en-US (side note: don't touch Yahoo Japan), so IMO you need a layout fix if a searchplugin as a smaller icon.
tracking-fennec: ? → -

Comment 5

11 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
tracking-fennec: - → ---
Last Resolved: 11 months ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.