1165045 - Don't create nodes with empty text in the call tree

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v2

Lol test failures.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8606013 [details] [diff] [review]
v2

Review of attachment 8606013 [details] [diff] [review]:
-----------------------------------------------------------------

Nice -- notice render improvements?

Comment 4

[Victor Porof [:vporof][:vp]]

No :( But it can't hurt.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6fa0256518e3

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6fa0256518e3

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8606013 [details] [diff] [review]
v2


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d39b7bb9acd1

Comment 9

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8606013 [details] [diff] [review]
v2

Change approved to skip one train as part of the spring campaign.