1165394 - L10n sizing issues with New Tab intro

Status: RESOLVED DUPLICATE of bug 1172987

(Firefox :: New Tab Page, defect)

Description

[Théo Chevalier]

Attachment: Nightly, French

The New Tab intro has a few issues on localized builds:

- Menu title overflows on the right margin

- "Example Title" is not localized (Missing string).

- "Back" and "Continue the tour" buttons have fixed width (150px) and are truncating long translations. Width should be dynamic here.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Italian build

In case of Italian it's the last item.

The same issues happen in the real menu, that's tracked in bug 1164594 (I guess the fix should replicate the real behavior).

Comment 2

[Ed Lee :Mardak]

(In reply to Théo Chevalier [:tchevalier] from comment #0)
> - "Example Title" is not localized (Missing string).
This string is also missing from Aurora 40. To not break string freeze, I can think of some quick options:

- use some other new tab string, e.g.,
newtab.intro.header.welcome=Welcome to New Tab on %1$S!
newtab.intro.header.update=New Tab got an update!

- use brandShortName "Firefox" as the tile title

I'm assuming it will not be acceptable to have "Example Title" show up in localized builds.

Any other suggestions? Or do we just fix the string and request approval for aurora?

Comment 3

[Francesco Lodolo [:flod]]

"Example Title" is definitely bad, the UI looks half translated.

What about using "www.mozilla.org" or similar? Tiles usually have URLs in that position, and we won't need a localizable string for that. 

I'd be absolutely fine also with using "Mozilla Firefox", "Mozilla", or "Firefox" from branding.properties

Comment 4

[Ed Lee :Mardak]

(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #3)
> What about using "www.mozilla.org" or similar? Tiles usually have URLs in
> that position, and we won't need a localizable string for that. 
Aha! Clever. Let's do that!

Comment 5

[Ed Lee :Mardak]

Let's focus this bug on the sizing issues: menu, button, etc.

I split off the Example Title to bug 1165430.

Comment 8

[Ed Lee :Mardak]

Is there anything else in this bug that wasn't covered by bug 1172987? That fixed the menu sizing and changed the buttons to have min-width 150px instead of fixed width 150px.

If not, we can mark this dupe of bug 1172987.

Comment 9

[Ed Lee :Mardak]

Attachment: screenshot of fr l10n nightly with extra text

screenshot with edited text from a firefox-41.0a1.fr.mac.dmg build 12-Jun-2015 13:13  http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

Comment 11

[Francesco Lodolo [:flod]]

Just confirming that everything looks good from there too, thanks.