Closed Bug 1166210 Opened 10 years ago Closed 9 years ago

Remove ServicesSetting changes listener in NfcContentHelper

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: allstars.chh, Assigned: tnguyen)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
2.35 KB, patch
tnguyen
: review+
Details | Diff | Splinter Review
In Bug 1058440 we enabled NFC logging in Settings, however the logging doesn't work for child Process, for example, NfcContentHelper running on child process.
Assignee: nobody → tnguyen
Hi Yoshi The issue depends on Bug 1063783 which seems not be looked into for a long time. I am not sure if the issue 1063783 could be fixed. There's a way that could resolve this bug: - Observe SettingService Debug-Option changes in Nfc.js which runs in parent process - Notify to all child processes which NfcContentHelper are running on, using sendAsyncMessage, then child processes decide to enable/disable debugging based on the message content Please let me know if you have any idea or suggestion. Thanks
Flags: needinfo?(allstars.chh)
Status: NEW → ASSIGNED
(In reply to Thomas Nguyen[:tnguyen][:thomas][:nguyen] from comment #1) > The issue depends on Bug 1063783 Please confirm with Dimi with this. I don't quite understand why this depends on it.
Flags: needinfo?(allstars.chh)
I had a discussion with Dimi about SettingsService. Only js which run at parent process are allowed to access to SettingsService. NfcContentHelper could be run at both parent and child process, therefore I would like to remove code block related to SettingsService in NfcContentHelper. There's no need to depend on Bug 1063783 Thanks
Summary: enable NFC debug for child process → Remove ServicesSetting changes listener in NfcContentHelper
Attached patch Patch v1 (obsolete) — — Splinter Review
Patch V1, remove listeners
Attachment #8675607 - Flags: review?(allstars.chh)
Attachment #8675607 - Flags: review?(allstars.chh) → review+
Attached patch Patch v2 — — Splinter Review
Add reviewer in commit title.
Attachment #8675607 - Attachment is obsolete: true
Attachment #8677835 - Flags: review+
Attachment #8677835 - Attachment description: 0001-Bug-1166210-Remove-ServicesSetting-changes-listener-.patch → Patch v2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3d45414331aa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: