Closed Bug 1166210 Opened 5 years ago Closed 4 years ago
Setting changes listener in Nfc Content Helper
In Bug 1058440 we enabled NFC logging in Settings, however the logging doesn't work for child Process, for example, NfcContentHelper running on child process.
Assignee: nobody → tnguyen
Hi Yoshi The issue depends on Bug 1063783 which seems not be looked into for a long time. I am not sure if the issue 1063783 could be fixed. There's a way that could resolve this bug: - Observe SettingService Debug-Option changes in Nfc.js which runs in parent process - Notify to all child processes which NfcContentHelper are running on, using sendAsyncMessage, then child processes decide to enable/disable debugging based on the message content Please let me know if you have any idea or suggestion. Thanks
(In reply to Thomas Nguyen[:tnguyen][:thomas][:nguyen] from comment #1) > The issue depends on Bug 1063783 Please confirm with Dimi with this. I don't quite understand why this depends on it.
I had a discussion with Dimi about SettingsService. Only js which run at parent process are allowed to access to SettingsService. NfcContentHelper could be run at both parent and child process, therefore I would like to remove code block related to SettingsService in NfcContentHelper. There's no need to depend on Bug 1063783 Thanks
Summary: enable NFC debug for child process → Remove ServicesSetting changes listener in NfcContentHelper
Patch V1, remove listeners
Attachment #8675607 - Flags: review?(allstars.chh)
4 years ago
Attachment #8675607 - Flags: review?(allstars.chh) → review+
Add reviewer in commit title.
Attachment #8677835 - Attachment description: 0001-Bug-1166210-Remove-ServicesSetting-changes-listener-.patch → Patch v2
You need to log in before you can comment on or make changes to this bug.