Closed
Bug 1166679
Opened 9 years ago
Closed 9 years ago
Implement GetMessage function
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(feature-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed)
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
Details
Attachments
(2 files, 5 obsolete files)
Implement GetMessage function
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → shuang
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8648665 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8648725 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8649175 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8649176 -
Flags: review?(btian)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function
Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with comment addressed.
::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +845,5 @@
> +BluetoothMapSmsManager::HandleSmsMmsGetMessage(const ObexHeaderSet& aHeader)
> +{
> + MOZ_ASSERT(NS_IsMainThread());
> +
> + BluetoothService* bs = BluetoothService::Get();
Ensure |bs| is non-nullptr.
Attachment #8649176 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function
Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +850,5 @@
> +
> + InfallibleTArray<BluetoothNamedValue> data;
> + nsString name;
> + aHeader.GetName(name);
> + BT_APPEND_NAMED_VALUE(data, "name", name);
Maybe it will be better to call "handle" instead of "name" here.
Field/Header Name Value
Header Name Message Handle
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8649176 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
blocking-b2g: --- → 2.2r?
|
|
||
Comment 8•9 years ago
|
||
Revise flag to feature-b2g: 2.2r+ since MAP is required bluetooth feature for 2.2r.
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8649249 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•9 years ago
|
||
|
|
Assignee | |
Comment 11•9 years ago
|
||
|
|
Assignee | |
Comment 12•9 years ago
|
||
|
||
Comment 13•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
|
||
Comment 14•9 years ago
|
||
status-b2g-v2.2r:
--- → fixed
|
|
||
Comment 15•9 years ago
|
||
sorry i had to back this out in https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97
seems one change here was causing a bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-b2g37_v2_2r
Status: RESOLVED → REOPENED
Flags: needinfo?(shuang)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 16•9 years ago
|
||
I've found that Bug 1195710 v2.2r patch cause this bustage. I will fix it in bug 1195710.
Flags: needinfo?(shuang)
|
|
||
Comment 17•9 years ago
|
||
|
|
||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•