Implement GetMessage function

RESOLVED FIXED in Firefox 43, Firefox OS v2.2r

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

Tracking

(Blocks: 1 bug)

unspecified
FxOS-S7 (18Sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Assignee)

Description

3 years ago
Implement GetMessage function
(Assignee)

Updated

3 years ago
Blocks: 1141954
(Assignee)

Updated

3 years ago
Assignee: nobody → shuang
(Assignee)

Comment 1

2 years ago
Created attachment 8648665 [details] [diff] [review]
bug-1166679-mc.patch
(Assignee)

Updated

2 years ago
Depends on: 1166675
(Assignee)

Updated

2 years ago
Attachment #8648665 - Attachment is obsolete: true
(Assignee)

Comment 2

2 years ago
Created attachment 8648725 [details] [diff] [review]
bug-1166679-mc.patch
(Assignee)

Updated

2 years ago
Attachment #8648725 - Attachment is obsolete: true
(Assignee)

Comment 3

2 years ago
Created attachment 8649175 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function
(Assignee)

Comment 4

2 years ago
Created attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function
(Assignee)

Updated

2 years ago
Attachment #8649175 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8649176 - Flags: review?(btian)

Comment 5

2 years ago
Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function

Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +845,5 @@
> +BluetoothMapSmsManager::HandleSmsMmsGetMessage(const ObexHeaderSet& aHeader)
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  BluetoothService* bs = BluetoothService::Get();

Ensure |bs| is non-nullptr.
Attachment #8649176 - Flags: review?(btian) → review+
(Assignee)

Updated

2 years ago
Blocks: 1186836
(Assignee)

Comment 6

2 years ago
Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function

Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +850,5 @@
> +
> +  InfallibleTArray<BluetoothNamedValue> data;
> +  nsString name;
> +  aHeader.GetName(name);
> +  BT_APPEND_NAMED_VALUE(data, "name", name);

Maybe it will be better to call "handle" instead of "name" here.

Field/Header       Name               Value
Header                Name               Message Handle
(Assignee)

Updated

2 years ago
Attachment #8649176 - Attachment is obsolete: true
(Assignee)

Comment 7

2 years ago
Created attachment 8649249 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function, r=btian
(Assignee)

Updated

2 years ago
Depends on: 1195685
(Assignee)

Updated

2 years ago
blocking-b2g: --- → 2.2r?

Comment 8

2 years ago
Revise flag to feature-b2g: 2.2r+ since MAP is required bluetooth feature for 2.2r.
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
(Assignee)

Updated

2 years ago
Attachment #8649249 - Attachment is obsolete: true
(Assignee)

Comment 9

2 years ago
Created attachment 8659874 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function, r=btian (m-c)

Comment 10

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/e03440d6f249
(Assignee)

Comment 11

2 years ago
Created attachment 8659890 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function, r=btian (v2.2r)
(Assignee)

Comment 12

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e995c445f70a
https://hg.mozilla.org/mozilla-central/rev/e03440d6f249
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/1930fdae016a
status-b2g-v2.2r: --- → fixed
sorry i had to back this out in https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97

seems one change here was causing a bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-b2g37_v2_2r
Status: RESOLVED → REOPENED
status-b2g-v2.2r: fixed → affected
Flags: needinfo?(shuang)
Resolution: FIXED → ---
(Assignee)

Comment 16

2 years ago
I've found that Bug 1195710 v2.2r patch cause this bustage. I will fix it in bug 1195710.
Flags: needinfo?(shuang)
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/d5f192858ca3
status-b2g-v2.2r: affected → fixed

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.