1195710 - [MAP]Implement PushMessage function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Implement PushMessage function.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1195710-mc.patch

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8649267 [details] [diff] [review]
bug1195710-mc.patch

I think I need to handle bMessage body first, cancel the review.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1195710 - [MAP]Implement PushMessage function

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi Ben,
I write bMessage parser in bug 1166647 which can take care of major work for parsing. For complete specification complaint, I prefer to keep some unused member variables/functions for native charset support.

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8657715 [details] [diff] [review]
Bug 1195710 - [MAP]Implement PushMessage function

Review of attachment 8657715 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Please confirm whether to rebase on bug 1195685 that removes BT_APPEND_NAMED_VALUE macro.

::: dom/bluetooth/BluetoothCommon.h
@@ +251,5 @@
>  /**
> + * When receiving a MAP request of 'push message' from a remote device,
> + * we'll dispatch an event.
> + */
> +#define MAP_PUSH_MESSAGE_REQ_ID              "mappushmessagereq"

Group MAP related ID as PBAP [1].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/common/BluetoothCommon.h#198

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1195710 - [MAP]Implement PushMessage function, r=btian (m-c)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/af74f0f2ade6

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1195710 - [MAP]Implement PushMessage function, r=btian (v2.2r)

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=af74f0f2ade6

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/af74f0f2ade6

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Wesley,
Could you please set feature v2.2r+?

Comment 12

[Carsten Book [:Tomcat]]

Hi, this failed to apply:

dding 1195710 to series file
renamed 1195710 -> bug1195710-v22r.patch
applying bug1195710-v22r.patch
patching file dom/bluetooth/BluetoothCommon.h
Hunk #1 FAILED at 118
1 out of 1 hunks FAILED -- saving rejects to file dom/bluetooth/BluetoothCommon.h.rej
patching file dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
Hunk #1 FAILED at 326
Hunk #2 FAILED at 817
Hunk #3 FAILED at 982
3 out of 3 hunks FAILED -- saving rejects to file dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp.rej
patching file dom/bluetooth/bluedroid/BluetoothMapSmsManager.h
Hunk #1 FAILED at 93
1 out of 1 hunks FAILED -- saving rejects to file dom/bluetooth/bluedroid/BluetoothMapSmsManager.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh bug1195710-v22r.patch

could you take a look, thanks!

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi
It looks like the current v2.2r doesn't include patch sets:
1. bug1166679-v22r.patch
2. bug1186836-v22r.patch

bug1195710-v22r.patch depends on those two patches.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/25e7fdb60999

Comment 15

[Carsten Book [:Tomcat]]

sorry i had to back this out in https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97

seems one change here was causing a bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-b2g37_v2_2r

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1195710 - [MAP]Implement PushMessage function, r=btian (v2.2r)

Comment 17

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1195710 - [MAP]Implement PushMessage function, r=btian (V2.2r)

Rebase it again.

Comment 18

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Carsten Book [:Tomcat] from comment #15)
> sorry i had to back this out in
> https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97
> 
> seems one change here was causing a bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-
> b2g37_v2_2r

I found the bustage caused by this patch. I've rebase it again and it works locally. Sorry to increase your work load.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/be1aa17d4388

Comment 20

[Carsten Book [:Tomcat]]

(In reply to Shawn Huang [:shawnjohnjr] from comment #18)
> (In reply to Carsten Book [:Tomcat] from comment #15)
> > sorry i had to back this out in
> > https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97
> > 
> > seems one change here was causing a bustage like
> > https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-
> > b2g37_v2_2r
> 
> I found the bustage caused by this patch. I've rebase it again and it works
> locally. Sorry to increase your work load.

no worries and absolutely no problem :)