Closed Bug 1235368 Opened 4 years ago Closed 3 years ago

scroll position for restored inactive tabs is not remembered

Categories

(Firefox :: Session Restore, defect)

41 Branch
x86
Windows 7
defect
Not set

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox42 --- affected
firefox43 --- affected
firefox44 - wontfix
firefox45 - affected
firefox46 - affected

People

(Reporter: clemmm, Unassigned)

References

(Blocks 1 open bug)

Details

(4 keywords)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826023504

Steps to reproduce:

1. Enable "Show my windows and tabs from last time" and "Don't load tabs until selected".
2. In one tab, load a site that's scrollable and has a form for text input; scroll whatever amount and input whatever text in the form.
3. In another tab, load any site. Make this tab active before the next step.
4. Close the browser, then open it.
5. Repeat step 4, then select the tab from step 2.



Actual results:

Scroll position and form data for tab in step 2 are not restored.


Expected results:

Scroll position and form data for tab in step 2 are restored.

The mozregression tool produced this:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3e737d30f842a9cb961f962d8b5675624211463c&tochange=2434e8134f3f7d571dd199e0e6a95b88dd8b6daf
OS: Unspecified → Windows 7
Hardware: Unspecified → x86
Flags: needinfo?(ttaubert)
clemmm@gmail.com, 

Could you test with New Profile?
Create a new profile, you have the steps here:https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager
Flags: needinfo?(ttaubert) → needinfo?(clemmm)
(In reply to Alice0775 White from comment #3)
> clemmm@gmail.com, 
> 
> Could you test with New Profile?
> Create a new profile, you have the steps
> here:https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-
> firefox-profiles?redirectlocale=en-US&redirectslug=Managing-
> profiles#w_starting-the-profile-manager

I used a new profile with the mozregression-gui tool.
Flags: needinfo?(clemmm)
[Tracking Requested - why for this release]: Regression dataloss

I can reproduce on Beta44.0b2.
https://hg.mozilla.org/releases/mozilla-beta/rev/264b621288130410f5e8b901f81dda0c53a35b1d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 ID:20151221151411
Blocks: 1166763, 1166757
Status: UNCONFIRMED → NEW
Component: Untriaged → Session Restore
Ever confirmed: true
Flags: needinfo?(ttaubert)
Keywords: dataloss, regression
And I can reproduce the scroll position problem on Aurora45.0a2 and Nightly46.0a1 without e10s.
See Also: → 1235379
Mike, you fixed some problems with sessionstore and scroll positions lately (iirc). Hope you find some time to investigate, I won't in the near future :|
Flags: needinfo?(ttaubert) → needinfo?(mconley)
Jim, I would consider this blocking 44 release. Do you agree? This is non-e10s based on the comments above. Could you please help get this investigated soon as we enter RC mode in a week? Thanks!
Flags: needinfo?(jmathies)
(In reply to Tim Taubert [:ttaubert] from comment #7)
> Mike, you fixed some problems with sessionstore and scroll positions lately
> (iirc). Hope you find some time to investigate, I won't in the near future :|

mconley is working on e10s. sworkman can you assist us here in carving out some time for him to look at this?
Flags: needinfo?(sworkman)
Flags: needinfo?(mconley)
Flags: needinfo?(jmathies)
Keywords: productwanted
(In reply to Jim Mathies [:jimm] from comment #9)
> (In reply to Tim Taubert [:ttaubert] from comment #7)
> > Mike, you fixed some problems with sessionstore and scroll positions lately
> > (iirc). Hope you find some time to investigate, I won't in the near future :|
> 
> mconley is working on e10s. sworkman can you assist us here in carving out
> some time for him to look at this?

s/him/tim
(In reply to Jim Mathies [:jimm] from comment #9)
> mconley is working on e10s. sworkman can you assist us here in carving out
> some time for him to look at this?

I'm not working Firefox Desktop anymore. I moved to the NSS team and have quite a lot on my plate there. But I'll let Steve respond.
Ok,, lets move this over to Nick on the firefox front end team.
Flags: needinfo?(sworkman) → needinfo?(nnguyen)
Too late for Fx44, wontfixing now.
Tracking for 45+ since this is a recent regression. 
Nick can you take this or help find an owner for this?
Justin can you help find an owner for this? I'm not sure it should block release to be honest. But it's been around a while. I'd like to either find someone to take it on, or drop tracking.
Flags: needinfo?(dolske)
Comment 0 and the regressing bugs seem to indicate this is a regression in Firefox 41, so I don't think it can be a release blocker at this point.

Scroll position being lost seems like a fairly minor issue, but form data would be more alarming. However, I can't reproduce lost of (what we call) form data... If I type some text into the search boxes on the https://bugzilla.mozilla.org front page and restart the browser, the tab and that text is restored when "Show my windows and tabs from last time" is enabled.
Flags: needinfo?(dolske)
Summary: scroll position/form data for restored inactive tabs is not remembered → scroll position for restored inactive tabs is not remembered
If we're not able to reproduce the form data loss, I think we should drop tracking here.
Blocks: fx-qx
I can no longer reproduce this bug per steps in comment 0. Please re-test this to confirm.
Keywords: qawanted
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #20)
> I can no longer reproduce this bug per steps in comment 0. Please re-test
> this to confirm.

Yep, I can confirm that I cannot reproduce the problem on Firefox45.0.2ESR, 46.0, 47.0a2 and 49.0a1 as well.
Ok, let's call this WFM then. Please reopen with STR if someone can reproduce this on current Firefox releases.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(nnguyen)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.