1167459 - Skip rendering function name nodes if there's no name available (e.g. for C++ pseudoframes)

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8609095 [details] [diff] [review]
v1

Review of attachment 8609095 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/performance.inc.css
@@ -330,5 @@
> -.call-tree-name[value=""],
> -.call-tree-url[value=""],
> -.call-tree-line[value=""],
> -.call-tree-column[value=""],
> -.call-tree-host[value=""] {

Do we not need these for other fields other than name that are empty? Or I guess we just check each field before creating an element, like this patch.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8609095 [details] [diff] [review]
> v1
> 
> Review of attachment 8609095 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/shared/devtools/performance.inc.css
> @@ -330,5 @@
> > -.call-tree-name[value=""],
> > -.call-tree-url[value=""],
> > -.call-tree-line[value=""],
> > -.call-tree-column[value=""],
> > -.call-tree-host[value=""] {
> 
> Do we not need these for other fields other than name that are empty? Or I
> guess we just check each field before creating an element, like this patch.

Those were removed in that one bug that made the tree amazing.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/80e0de901ed6

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/80e0de901ed6

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8609095 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 7

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11c00eb7c82a

Comment 8

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8609095 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.