Skip rendering function name nodes if there's no name available (e.g. for C++ pseudoframes)

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: vporof, Assigned: vporof)

Tracking

(Blocks 1 bug)

unspecified
Firefox 41
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment)

No description provided.
Blocks: perf-perf
Posted patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8609095 - Flags: review?(jsantell)
Comment on attachment 8609095 [details] [diff] [review]
v1

Review of attachment 8609095 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/performance.inc.css
@@ -330,5 @@
> -.call-tree-name[value=""],
> -.call-tree-url[value=""],
> -.call-tree-line[value=""],
> -.call-tree-column[value=""],
> -.call-tree-host[value=""] {

Do we not need these for other fields other than name that are empty? Or I guess we just check each field before creating an element, like this patch.
Attachment #8609095 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8609095 [details] [diff] [review]
> v1
> 
> Review of attachment 8609095 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/shared/devtools/performance.inc.css
> @@ -330,5 @@
> > -.call-tree-name[value=""],
> > -.call-tree-url[value=""],
> > -.call-tree-line[value=""],
> > -.call-tree-column[value=""],
> > -.call-tree-host[value=""] {
> 
> Do we not need these for other fields other than name that are empty? Or I
> guess we just check each field before creating an element, like this patch.

Those were removed in that one bug that made the tree amazing.
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/80e0de901ed6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Flags: qe-verify-
Comment on attachment 8609095 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8609095 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8609095 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.
Attachment #8609095 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.