Closed Bug 1167963 Opened 9 years ago Closed 9 years ago

FrameNode should not export `isContent`

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed, firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

v1
8.44 KB, patch
jsantell
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Attached patch v1 — — Splinter Review 
Assignee: nobody → vporof
Status: NEW → ASSIGNED

        Attachment #8609871 -
        Flags: review?(jsantell)

    
    

    
  
Comment on attachment 8609871 [details] [diff] [review]
v1

Review of attachment 8609871 [details] [diff] [review]:
-----------------------------------------------------------------

Is offsetMarkerTimes used here? Why export it now?

        Attachment #8609871 -
        Flags: review?(jsantell) → review+

    
    

    
  
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8609871 [details] [diff] [review]
> v1
> 
> Review of attachment 8609871 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is offsetMarkerTimes used here? Why export it now?

Accidental, removing.

    
  
Blocks: perf-40-uplifts

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fcf3b77a75a3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: qe-verify-

    
    

    
  
Comment on attachment 8609871 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

        Attachment #8609871 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

    
    

    
  
Comment on attachment 8609871 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.

        Attachment #8609871 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.