1168118 - Migrate test_sms_contact_input_validation.py to Gij

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Original test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_contact_input_validation.py

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

I'm moving a bit forward while bug 1156753 lands. See the diff between bug 1156753 and this one at [1]

[1] https://github.com/JohanLorenzo/gaia/compare/bug-1156753...JohanLorenzo:bug-1168118

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

Hey Johan,

Since patch for bug 1156753 is landed, could you please rebase this PR on the latest master and ask for review whenever you're ready?

Thanks!

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

Rebased and TH shows green, except on Gij10. This failure also happens in other PRs.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

Sorry for the delay, was a bit busy these days.

Mostly looks good, just several nits. Mainly I'm worried about new method for adding recipients and we renamed "composer" to "new_message" recently (yeah, I know that's hard to contribute when code base is changing rapidly).

Thanks a lot!

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

Ready for another round of review!

Clearing John's review as he's out for this week.

Comment 7

[Johan Lorenzo [:jlorenzo]]

I had to make a workaround because of bug 1097575.

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8610473 [details] [review]
[gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master

LGTM, let's land this once Treeherder is green!

Looks like something wrong with Treeherder - the last run is quite "colorful" :) 

Thanks!

Comment 9

[Johan Lorenzo [:jlorenzo]]

Commits squashed and here are green Gij jobs: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=859c239f9f9990e27503c35b64298086b46c2ab6

Merged in master at: https://github.com/mozilla-b2g/gaia/commit/16729c45da3d3ed9640d6ae323bdc0080ad5ddc9