Closed
Bug 1168118
Opened 8 years ago
Closed 8 years ago
Migrate test_sms_contact_input_validation.py to Gij
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jlorenzo
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master I'm moving a bit forward while bug 1156753 lands. See the diff between bug 1156753 and this one at [1] [1] https://github.com/JohanLorenzo/gaia/compare/bug-1156753...JohanLorenzo:bug-1168118
Attachment #8610473 -
Flags: review?(jdorlus)
Attachment #8610473 -
Flags: review?(azasypkin)
Comment 3•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master Hey Johan, Since patch for bug 1156753 is landed, could you please rebase this PR on the latest master and ask for review whenever you're ready? Thanks!
Attachment #8610473 -
Flags: review?(azasypkin)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master Rebased and TH shows green, except on Gij10. This failure also happens in other PRs.
Attachment #8610473 -
Flags: review?(azasypkin)
Assignee | ||
Updated•8 years ago
|
QA Whiteboard: [fxosqa-auto-s17+,s18]
Comment 5•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master Sorry for the delay, was a bit busy these days. Mostly looks good, just several nits. Mainly I'm worried about new method for adding recipients and we renamed "composer" to "new_message" recently (yeah, I know that's hard to contribute when code base is changing rapidly). Thanks a lot!
Attachment #8610473 -
Flags: review?(azasypkin)
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master Ready for another round of review! Clearing John's review as he's out for this week.
Attachment #8610473 -
Flags: review?(jdorlus) → review?(azasypkin)
Assignee | ||
Comment 7•8 years ago
|
||
I had to make a workaround because of bug 1097575.
Depends on: 1097575
Comment 8•8 years ago
|
||
Comment on attachment 8610473 [details] [review] [gaia] JohanLorenzo:bug-1168118 > mozilla-b2g:master LGTM, let's land this once Treeherder is green! Looks like something wrong with Treeherder - the last run is quite "colorful" :) Thanks!
Attachment #8610473 -
Flags: review?(azasypkin) → review+
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•8 years ago
|
||
Commits squashed and here are green Gij jobs: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=859c239f9f9990e27503c35b64298086b46c2ab6 Merged in master at: https://github.com/mozilla-b2g/gaia/commit/16729c45da3d3ed9640d6ae323bdc0080ad5ddc9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•