1168251 - updater binary is not copied to the test dir until after invoking build a 2nd time

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This is essentially the same issue that bug 934070 is attempting to fix but has not as of yet fixed.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8610316 [details] [diff] [review]
patch rev1

glandium, I saw your input in bug 934070... do you know of a better way of dealing with this?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #0)
> This is essentially the same issue that bug 934070 is attempting to fix but
> has not as of yet fixed.

I don't think it is the same issue at all. My  guess is (since you didn't file with much information) that you're trying to fix bug 1162326.

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to Mike Hommey [:glandium] from comment #3)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #0)
> > This is essentially the same issue that bug 934070 is attempting to fix but
> > has not as of yet fixed.
> 
> I don't think it is the same issue at all. My  guess is (since you didn't
> file with much information) that you're trying to fix bug 1162326.
I verified that the patch does in fact fix the issue of the updater binary not being copied until the 2nd invocation of mach build toolkit/mozapps/update/.

Why don't you think it is the same issue? Wouldn't that bug be easily fixed by just doing things in libs then?

Comment 5

[Robert Strong (they/them - no direct email)]

Note: this is on Windows but I have also seen this on Mac OS X when my MacBook was still working.

Comment 6

[Robert Strong (they/them - no direct email)]

Perhaps I could use PROGRAMS_DEST to get around this?

Comment 7

[Mike Hommey [:glandium]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #4)
> Why don't you think it is the same issue?

Because bug 934070 is exclusively about the rules in browser/app/Makefile.in for mac builds, which are not the same as those in toolkit/mozapps/update.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #5)
> Note: this is on Windows

Please provide the error you're trying to fix, then. Because bug 1162326 and bug 934070 are exclusively mac issues.

Comment 9

[Robert Strong (they/them - no direct email)]

(In reply to Mike Hommey [:glandium] from comment #8)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #5)
> > Note: this is on Windows
> 
> Please provide the error you're trying to fix, then. Because bug 1162326 and
> bug 934070 are exclusively mac issues.
The error or more precisely the issue is the "updater binary is not copied to the test dir until after invoking build a 2nd time". I'll try to figure out the best approach to solve this with my limited knowledge of the build system and re-submit. I suspect though I'm not entirely sure with my limited knowledge of the build system that the reason that bug 934070 is Mac only is because that code block only applies to Mac. As I said previously, I have seen this before on Mac and specifically with the Mac only updater libs section. This has to do with Windows because these are test files that need to be copied after they are compiled similar to how on Mac the bundle needs to be created as in bug 934070.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: patch

This fixes it for me.

If you prefer I can do this in the tools tier since this file is used for tests and the tools tier is for "installing tests and other support tools."

Comment 11

[Robert Strong (they/them - no direct email)]

Attachment: patch - use tools tier

In case you'd prefer going with the tools tier per the docs. On Windows I verified that this bug exists without either of these patches and that both of these patches fix this bug.

Comment 12

[Mike Hommey [:glandium]]

This all stems from the fact that we don't recurse on non-toplevel compile, and kinda sorta rely on libs doing it, but that's more or less botched. So let's fix that instead.

Comment 13

[Mike Hommey [:glandium]]

Attachment: 0001-Bug-1168251-Do-a-partial-recursion-when-doing-make-C.patch

Comment 14

[Gregory Szorc [:gps]]

Comment on attachment 8610417 [details] [diff] [review]
0001-Bug-1168251-Do-a-partial-recursion-when-doing-make-C.patch

Review of attachment 8610417 [details] [diff] [review]:
-----------------------------------------------------------------

I bet this breaks someone's workflow. Let's land it.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a19fd434d22a

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a19fd434d22a

Comment 17

[Robert Strong (they/them - no direct email)]

That fixed this. Thanks!