1169937 - No localized nightly builds of Firefox (since May 27)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bartosz Piec]

There are no latest pl localization builds for Firefox Nightly for win32 on FTP: ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/ (they exist only for linux and mac). The last version I found was here: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/05/2015-05-26-03-02-02-mozilla-central-l10n/

Comment 1

[Mike Hommey [:glandium]]

Error is:
07:55:58     INFO -  c:\builds\moz2_slave\m-cen-w32-l10n-ntly-1-00000000\build\mozilla-central\security\nss\lib\util\secasn1.h(15) : fatal error C1083: Cannot open include file: 'plarena.h': No such file or directory
07:55:58     INFO -  ../../coreconf/rules.mk:384: recipe for target 'c:/builds/moz2_slave/m-cen-w32-l10n-ntly-1-00000000/build/mozilla-central/obj-l10n/security/nss/lib/util/quickder.obj' failed

and is caused by bug 1168251. Can't have nice things.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Explicitly build the export target only under config/ during l10n builds

The issue roots in the fact that l10n builds are doing "make -C config", which recurses DIRS for export, libs and tools, and now recurses directories under config/ for compile. Now, the reason we're doing "make -C config" is that we want nsinstall to be built, which happens during export. So just do that target instead of all of them. This has the advantage of working across all branches, too.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8613323 [details] [diff] [review]
Explicitly build the export target only under config/ during l10n builds

r+. Out of curiosity, is nsinstall a special case to get built in export rather than tools ?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Nick Thomas [:nthomas] from comment #4)
> r+. Out of curiosity, is nsinstall a special case to get built in export
> rather than tools ?

Yes, there are explicit dependencies that make it built early during the build, because everything else needs it. Building it as part of export is one of those.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/build/mozharness/rev/bba5111a539e

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/build/mozharness/rev/3030ddc03dd3

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f351a43d8a74

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f351a43d8a74

Comment 11

[Francesco Lodolo [:flod]]

Amending subject since it's not just win32.

Comment 12

[Axel Hecht [:Pike]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-06-02-05-52-37-mozilla-central-l10n/mozilla-central-linux-l10n-nightly-1-unknown-bm73-build1-build2.txt.gz has


07:36:02    FATAL - Uncaught exception: Traceback (most recent call last):
07:36:02    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1288, in run
07:36:02    FATAL -     self.run_action(action)
07:36:02    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1230, in run_action
07:36:02    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
07:36:02    FATAL -   File "/builds/slave/m-cen-lx-l10n-ntly-1-000000000/scripts/mozharness/base/script.py", line 1171, in _possibly_run_method
07:36:02    FATAL -     return getattr(self, method_name)()
07:36:02    FATAL -   File "scripts/scripts/desktop_l10n.py", line 558, in setup
07:36:02    FATAL -     self._run_make_in_config_dir()
07:36:02    FATAL -   File "scripts/scripts/desktop_l10n.py", line 594, in _run_make_in_config_dir
07:36:02    FATAL -     return self._make(target='export', cwd=config_dir, env=env)
07:36:02    FATAL -   File "scripts/scripts/desktop_l10n.py", line 669, in _make
07:36:02    FATAL -     make = make + target
07:36:02    FATAL - TypeError: can only concatenate list (not "str") to list
07:36:02    FATAL - Running post_fatal callback...
07:36:02    FATAL - Exiting -1
program finished with exit code 255

Comment 13

[Rail Aliiev [:rail]]

Looks like "...target=['export']..." may fix that.

Comment 14

[Mike Hommey [:glandium]]

(In reply to Rail Aliiev [:rail] from comment #13)
> Looks like "...target=['export']..." may fix that.

Pushed that as a fixup:
https://hg.mozilla.org/build/mozharness/rev/874bb5dc8e71
https://hg.mozilla.org/build/mozharness/rev/476752fc4ea8

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36d7559859ed

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36d7559859ed

Comment 18

[Rail Aliiev [:rail]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=14be4237f855&filter-searchStr=l10n&exclusion_profile=false shows 2 green linux64 builds now. Hopefully it will work for other platforms as well.

Comment 19

[Francesco Lodolo [:flod]]

We're missing localized builds again from the last 3 days
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

The only one updated is Arabic. Is it still the same bug or a new one?

Comment 20

[Mike Hommey [:glandium]]

No, it's a different one.