1169120 - Waterfall should preserve the currently selected marker after resizing

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

When the window is resized, the selection is lost. This used to be implemented before bug 1152421, but it was very buggy and didn't really work. With the rewrite, it should now be easier to properly handle this.

Comment 1

[Victor Porof [:vporof][:vp]]

Wanna fix this now

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8611631 [details] [diff] [review]
v1

Review of attachment 8611631 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/AbstractTreeItem.jsm
@@ +329,5 @@
> +   * Calls the provided function on all the descendants of this item.
> +   * If this item was never expanded, then no descendents exist yet.
> +   * @param function cb
> +   */
> +  traverse: function(cb) {

should add tests for these later on our actual widgets

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/103c08c8fc61

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/103c08c8fc61

Comment 6

[Victor Porof [:vporof][:vp]]

Note that this doesn't handle meta markers, since they are new objects everytime the waterfall is rebuilt. Will handle this is a different bug.

Comment 7

[Andrei Vaida [:avaida]]

Setting [qe-verify-] since this is already covered by automated testing.