Closed Bug 1169120 Opened 7 years ago Closed 7 years ago

Waterfall should preserve the currently selected marker after resizing

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

When the window is resized, the selection is lost. This used to be implemented before bug 1152421, but it was very buggy and didn't really work. With the rewrite, it should now be easier to properly handle this.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Summary: Waterfall should properly maintain selection after resizing → Waterfall should preserve the currently selected marker after resizing
Wanna fix this now
Attached patch v1Splinter Review
Attachment #8611631 - Flags: review?(jsantell)
Comment on attachment 8611631 [details] [diff] [review]
v1

Review of attachment 8611631 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/AbstractTreeItem.jsm
@@ +329,5 @@
> +   * Calls the provided function on all the descendants of this item.
> +   * If this item was never expanded, then no descendents exist yet.
> +   * @param function cb
> +   */
> +  traverse: function(cb) {

should add tests for these later on our actual widgets
Attachment #8611631 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/103c08c8fc61
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Note that this doesn't handle meta markers, since they are new objects everytime the waterfall is rebuilt. Will handle this is a different bug.
Setting [qe-verify-] since this is already covered by automated testing.
Flags: qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.