1169504 - Telephony marionette-webapi test, test_outgoing_radio_off.js, failed on emulator-kk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

https://treeherder.allizom.org/#/jobs?repo=try&revision=6794612b4298&filter-searchStr=mnw&exclusion_profile=false

16:48:52     INFO -  05-27 16:23:13.230 I/Gecko   (   58): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_outgoing_radio_off.js | undefined - got 6, expected 0

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Just share some experiences: yesterday I hit this when I ran a bunch of telephony tests at once; I didn't see this if I simply ran this single tests.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #0)
> https://treeherder.allizom.org/#/jobs?repo=try&revision=6794612b4298&filter-
> searchStr=mnw&exclusion_profile=false
> 
> 16:48:52     INFO -  05-27 16:23:13.230 I/Gecko   (   58): MARIONETTE TEST
> RESULT:TEST-UNEXPECTED-FAIL | test_outgoing_radio_off.js | undefined - got
> 6, expected 0

We expect that emulator-kk dials emergency call via slot 0, but it dials via slot 6.
When dialling emergency call, the cardState of slot 6 didn't finish updating yet. So TelephonyService chose slot 6 to dial emergency call.

> 16:48:51     INFO -  05-27 16:23:06.040 I/Gecko   (   58): MobileConnectionProvider[6]: setRadioEnabled: false
> 16:48:51     INFO -  05-27 16:23:10.270 I/Gecko   (   58): TelephonyService: Dialing 112, clientId: 0
> 16:48:51     INFO -  05-27 16:23:10.420 I/Gecko   (   58): MobileConnectionProvider[6]: setRadioEnabled: true
> 16:48:51     INFO -  05-27 16:23:10.540 I/Gecko   (   58): IccService: notifyCardStateChanged for service Id: 6, CardState: 4294967295

Comment 3

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Just share some experiences: yesterday I hit this when I ran a bunch of
> telephony tests at once; I didn't see this if I simply ran this single tests.

Thanks for sharing.
I couldn't reproduce this on emulator-x86-kk locally (even ran all telephony tests), looks like emulator-kk on treeherder is pretty slow and cause this failure.
Reducing the number of sim enabled (bug 1163483) might help this. I have no idea how much it will help, but I can give it a shot.

Comment 4

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> Reducing the number of sim enabled (bug 1163483) might help this. I have no
> idea how much it will help, but I can give it a shot.

Let's see does it help: https://treeherder.allizom.org/#/jobs?repo=try&revision=6c502634de82&exclusion_profile=false

Comment 5

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #4)
> (In reply to Edgar Chen [:edgar][:echen] from comment #3)
> > Reducing the number of sim enabled (bug 1163483) might help this. I have no
> > idea how much it will help, but I can give it a shot.
> 
> Let's see does it help:
> https://treeherder.allizom.org/#/
> jobs?repo=try&revision=6c502634de82&exclusion_profile=false

Another try: https://treeherder.allizom.org/#/jobs?repo=try&revision=460c52eac3d7&exclusion_profile=false

Comment 6

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #5)
> Another try:
> https://treeherder.allizom.org/#/
> jobs?repo=try&revision=460c52eac3d7&exclusion_profile=false

Enabling 2 sim only (bug 1163483) improves a lot, but I still saw the same failure a few times, although the fail rate is low.

Comment 7

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Another thought: wait icc status to finish updating when enabling/disabling radio power.

try: https://treeherder.allizom.org/#/jobs?repo=try&revision=cfb8c8670fd6&exclusion_profile=false

Comment 8

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #7)
> Created attachment 8613403 [details] [diff] [review]
> Patch, v1
> 
> Another thought: wait icc status to finish updating when enabling/disabling
> radio power.
> 
> try:
> https://treeherder.allizom.org/#/
> jobs?repo=try&revision=cfb8c8670fd6&exclusion_profile=false

Another try:
https://treeherder.allizom.org/#/jobs?repo=try&revision=03bab49390c2&exclusion_profile=false

Comment 9

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 10

[Edgar Chen [:edgar]]

Comment on attachment 8613837 [details] [diff] [review]
Patch, v2

Review of attachment 8613837 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8613837 [details] [diff] [review]
Patch, v2

Review of attachment 8613837 [details] [diff] [review]:
-----------------------------------------------------------------

Yay~ let's ship it. Thanks for this :)

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/a1c63bd7e0b9

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1c63bd7e0b9