1169508 - Migrate gaia-text-input to input text box in prompt dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Sherman Chen [:chens] (inactive)]

We should use normal text box to have correct font size in prompt dialog.

Comment 1

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request to smart-modal-dialog

John, would you review this patch? thanks!

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8614500 [details] [review]
Pull request to smart-modal-dialog

looks good to me.

Comment 3

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request to master

John, would you review this patch? thanks!

Comment 4

[Sherman Chen [:chens] (inactive)]

Land on smart-modal-dialog: https://github.com/smart-components/smart-modal-dialog/commit/36275a3742389663d16c61b53a426fd3401e4850

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8615877 [details] [review]
Pull request to master

Focus lost issue found with the following STR:
1. open UI test and open a prompt
2. go back to home
3. open app deck
4. open UI test app again <== focus goes to UI test app instead of dialog.

I also tested alert and confirm. They are affected, too.

The reason I found it is that you haven't changed any lines of focus to handle the focus of smart-input-dialog.

Comment 6

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8615877 [details] [review]
Pull request to master

John, I've put focus related fixes for smart-modal-dialog and smart-input-dialog, would you review this again? thanks!

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8615877 [details] [review]
Pull request to master

Looks good to me.

Comment 8

[Sherman Chen [:chens] (inactive)]

master: https://github.com/mozilla-b2g/gaia/commit/b387bcad9bf8389580a8ae133b071053cfc9c30f