117028 - Hebrew character sometimes show up as Question mark on MacOS 9

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Frank Tang]

On MacOS 9, if the first character in a RTL run is a 0x20 (space) and the last
one is a Hebrew , then it will be drawn as '?' . then the last Hebrew will be
show as '?'

Comment 1

[Frank Tang]

Attachment: correct display of the hebrew page (For both)

Comment 2

[Frank Tang]

Attachment: logical page

Comment 3

[Frank Tang]

Attachment: visual page

Comment 4

[Frank Tang]

Attachment: logical page

Comment 5

[Frank Tang]

Attachment: visual page

Comment 6

[Frank Tang]

to reproduce this problem, we need to fix other bigger problem first- 
After I apply patch in bug 116976 and bug 116982. MacOS X display correctly of
the  above two page (without bidi support). MacOS 9 still have this problem. 
The last characters (the left most) in the line below
Text and number display as "?"
and the last character (the left most) in the line below
Text with English
also display as "?"

I got a patch

Comment 7

[Frank Tang]

Attachment: patch for the '?' problem

Comment 8

[Frank Tang]

I should try the patch on MacOS X also. Have not done it yet.
What happen is we look at the wrong character when wer are in right to left
mode. We should look at the end of the buffer instead of the beginning of the
buffer in that condiction. 

Comment 9

[Shanjian Li]

looks fine. r=shanjian

Comment 10

[Frank Tang]

Comment on attachment 62816 [details] [diff] [review]
patch for the '?' problem

http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view  iin bug 107098
obsolete this patch

Comment 11

[Frank Tang]

I believe the following three patch should fix most mac os hewbrew problem

big endian issue in nsFrame.cpp
see latest patch in http://bugzilla.mozilla.org/show_bug.cgi?id=116976

big endian issue in nsBidiImp.cpp 
http://bugzilla.mozilla.org/attachment.cgi?id=62917&action=view

turn off hebrew reordering and do not report hint on mac gfx
http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view

Comment 12

[Frank Tang]

this should be fixed right now.