Closed
Bug 1170567
Opened 9 years ago
Closed 9 years ago
Back out buildid-upgrade-whatsnew patch from bug 1143875 after watershed release
Categories
(Firefox :: Tours, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox39 | + | unaffected |
firefox40 | + | fixed |
firefox41 | --- | unaffected |
People
(Reporter: Gijs, Unassigned)
References
Details
Attachments
(1 file)
Server config should mean we're not in an incredible hurry to do this straight away, but we should ideally do it by the end of this week so we don't randomly forget it and end up breaking beta things.
Comment 1•9 years ago
|
||
Tracked to make sure we don't forget.
status-firefox40:
--- → affected
tracking-firefox40:
--- → +
Reporter | ||
Comment 2•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox41:
--- → unaffected
Updated•9 years ago
|
Component: General → Tours
Comment 3•9 years ago
|
||
rstrong, I think we would benefit from having some mechanism to force a whatsnew even when the version is not changing, and this patch gives us that on Aurora and Beta. The pref startup.homepage_override_url is "" there, although not on nightly. What do you think of leaving this in, or adding some new code block just for OVERRIDE_NEW_BUILD_ID ?
Flags: needinfo?(robert.strong.bugs)
Comment 4•9 years ago
|
||
I'm fine with leaving the code in but I really don't know the code in browser/components/nsBrowserContentHandler.js very well. Probably best to ask gavin.
Flags: needinfo?(robert.strong.bugs)
Updated•9 years ago
|
Comment 5•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #0) > Server config should mean we're not in an incredible hurry to do this > straight away, but we should ideally do it by the end of this week so we > don't randomly forget it and end up breaking beta things. We need this patch in, and the server config set, to show the whatsnew page. Ideally we'd wait until most users have a build later than 20150602163057, to catch the maximum audience. I don't know of anywhere to see that info that though. But definitely should back it out before the beta -> release merge on June 22.
Comment 6•9 years ago
|
||
I'll put this on my list of things to check on before beta 5.
tracking-firefox39:
--- → +
Comment 7•9 years ago
|
||
Comment #5 is incorrect. We can backout the patch at any time.
Comment 8•9 years ago
|
||
I've pushed the backout to Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/3830ac632774
Updated•9 years ago
|
Version: 38 Branch → 40 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•