Closed Bug 1170567 Opened 5 years ago Closed 5 years ago

Back out buildid-upgrade-whatsnew patch from bug 1143875 after watershed release

Categories

(Firefox :: Tours, defect)

40 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox39 + unaffected
firefox40 + fixed
firefox41 --- unaffected

People

(Reporter: Gijs, Unassigned)

References

Details

Attachments

(1 file)

Server config should mean we're not in an incredible hurry to do this straight away, but we should ideally do it by the end of this week so we don't randomly forget it and end up breaking beta things.
Tracked to make sure we don't forget.
Component: General → Tours
rstrong, I think we would benefit from having some mechanism to force a whatsnew even when the version is not changing, and this patch gives us that on Aurora and Beta. The pref startup.homepage_override_url is "" there, although not on nightly.

What do you think of leaving this in, or adding some new code block just for OVERRIDE_NEW_BUILD_ID ?
Flags: needinfo?(robert.strong.bugs)
I'm fine with leaving the code in but I really don't know the code in browser/components/nsBrowserContentHandler.js very well. Probably best to ask gavin.
Flags: needinfo?(robert.strong.bugs)
No longer blocks: 1143875
Depends on: 1143875
(In reply to :Gijs Kruitbosch from comment #0)
> Server config should mean we're not in an incredible hurry to do this
> straight away, but we should ideally do it by the end of this week so we
> don't randomly forget it and end up breaking beta things.

We need this patch in, and the server config set, to show the whatsnew page. Ideally we'd wait until most users have a build later than 20150602163057, to catch the maximum audience. I don't know of anywhere to see that info that though.

But definitely should back it out before the beta -> release merge on June 22.
I'll put this on my list of things to check on before beta 5.
Comment #5 is incorrect. We can backout the patch at any time.
I've pushed the backout to Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/3830ac632774
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Version: 38 Branch → 40 Branch
See Also: → 1196530
You need to log in before you can comment on or make changes to this bug.