[Hackerplace] Add Developer Mode prompt

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: drs, Assigned: pdahiya)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spark])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We should add a Developer Mode prompt to Hackerplace when it's first started.
(Reporter)

Comment 1

3 years ago
Punam, can you take this? Thanks.
Component: Gaia → Gaia::Hackerplace
Flags: needinfo?(pdahiya)
(Assignee)

Comment 2

3 years ago
Assigning myself to work on this.
Flags: needinfo?(pdahiya)
(Assignee)

Updated

3 years ago
Assignee: nobody → pdahiya
(Reporter)

Updated

3 years ago
See Also: → bug 1171611
(Reporter)

Updated

3 years ago
Blocks: 1168567
(Reporter)

Updated

3 years ago
Summary: Add Developer Mode prompt → [Hackerplace] Add Developer Mode prompt
(Reporter)

Updated

3 years ago
See Also: → bug 1172051
(Assignee)

Comment 3

3 years ago
Created attachment 8616776 [details] [review]
PR with fix of Bug 1171596

Hi Michael

Attaching PR that shows dev mode prompt when hackerplace first starts if dev mode is not enabled on device. Please review. Thanks!
Attachment #8616776 - Flags: review?(mhenretty)
Comment on attachment 8616776 [details] [review]
PR with fix of Bug 1171596

Cool! The one weirdness is when I have the developer menu disabled, it makes it a little confusing to use this. Would be super cool if settings could enable developer menu when receiving this activity or something, but that is out of the scope for this bug.

I'm going to merge this so I can rebase my WIP against it.
Attachment #8616776 - Flags: review?(mhenretty) → review+
master: https://github.com/fxos/directory/commit/6e2fba893343a75256c1be6c48a276a5a5a1379f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

3 years ago
(In reply to Michael Henretty [:mhenretty] from comment #4)
> Comment on attachment 8616776 [details] [review]
> PR with fix of Bug 1171596
> 
> Cool! The one weirdness is when I have the developer menu disabled, it makes
> it a little confusing to use this. Would be super cool if settings could
> enable developer menu when receiving this activity or something, but that is
> out of the scope for this bug.

Unfortunately, for security reasons, we can't do this. See bug 1163889 comment 6 for context.
You need to log in before you can comment on or make changes to this bug.