Closed Bug 1171596 Opened 4 years ago Closed 4 years ago

[Hackerplace] Add Developer Mode prompt

Categories

(Firefox OS Graveyard :: Gaia::Hackerplace, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: pdahiya)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

42 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review
We should add a Developer Mode prompt to Hackerplace when it's first started.
Punam, can you take this? Thanks.
Component: Gaia → Gaia::Hackerplace
Flags: needinfo?(pdahiya)
Assigning myself to work on this.
Flags: needinfo?(pdahiya)
Assignee: nobody → pdahiya
See Also: → 1171611
Summary: Add Developer Mode prompt → [Hackerplace] Add Developer Mode prompt
See Also: → 1172051
Hi Michael

Attaching PR that shows dev mode prompt when hackerplace first starts if dev mode is not enabled on device. Please review. Thanks!
Attachment #8616776 - Flags: review?(mhenretty)
Comment on attachment 8616776 [details] [review]
PR with fix of Bug 1171596

Cool! The one weirdness is when I have the developer menu disabled, it makes it a little confusing to use this. Would be super cool if settings could enable developer menu when receiving this activity or something, but that is out of the scope for this bug.

I'm going to merge this so I can rebase my WIP against it.
Attachment #8616776 - Flags: review?(mhenretty) → review+
master: https://github.com/fxos/directory/commit/6e2fba893343a75256c1be6c48a276a5a5a1379f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
(In reply to Michael Henretty [:mhenretty] from comment #4)
> Comment on attachment 8616776 [details] [review]
> PR with fix of Bug 1171596
> 
> Cool! The one weirdness is when I have the developer menu disabled, it makes
> it a little confusing to use this. Would be super cool if settings could
> enable developer menu when receiving this activity or something, but that is
> out of the scope for this bug.

Unfortunately, for security reasons, we can't do this. See bug 1163889 comment 6 for context.
You need to log in before you can comment on or make changes to this bug.