Closed Bug 1171611 Opened 9 years ago Closed 9 years ago

[P2P Sharing] Add Developer Mode prompt

Categories

(Firefox OS Graveyard :: Gaia::P2P Sharing, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::P2P Sharing
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: pdahiya)

References

Details

(Whiteboard: [spark])

Attachments

(1 file, 1 obsolete file)

PR with fix of Bug 1171611
40 bytes, text/x-github-pull-request
drs
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #1171596 +++

We should add a Developer Mode prompt to P2P Sharing when it's first started.
Blocks: spark-p2p-sharing
No longer blocks: spark-hackerplace
Summary: Add Developer Mode prompt → [P2P Sharing] Add Developer Mode prompt
See Also: → 1172051
Attached file PR with fix of Bug 1171611 (obsolete) — 
Hi Doug
Attaching PR to display dev prompt for sharing app when developer mode is not enabled on device. Please review. Thanks!
Attachment #8616883 - Flags: review?(drs)
Sorry, setting review flag on correct PR. Thanks
Attachment #8616883 - Attachment is obsolete: true
Attachment #8616883 - Flags: review?(drs)
Attachment #8616885 - Flags: review?(drs)
Comment on attachment 8616885 [details] [review]
PR with fix of Bug 1171611

It's really cool how you did this. I'm glad it's so concise. Well done, Punam!

I left two comments on the PR describing very minor issues. Please fix those before merging.
Attachment #8616885 - Flags: review?(drs) → review+
Thanks Doug, patch updated with feedback and landed on master

https://github.com/fxos/sharing/commit/df42a5d877718ff38b808bc42d3583a891b9a167
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: