[Settings] Convert remaining switches to use gaia-switch component

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 6 obsolete attachments)

Comment hidden (empty)

Comment 1

2 years ago
Created attachment 8635013 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_convert_root_to_gaia_switch > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8635013 - Attachment is obsolete: true

Comment 2

2 years ago
Created attachment 8648502 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_root_switches > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Summary: [Settings] Convert building block switches to use gaia-switch in root panel → [Settings] Convert remaining switches to use gaia-switch component
(Assignee)

Updated

2 years ago
Attachment #8648502 - Attachment is obsolete: true

Comment 3

2 years ago
Created attachment 8651426 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_convert_network_operator_switch > mozilla-b2g:master
(Assignee)

Comment 4

2 years ago
Comment on attachment 8651426 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_convert_network_operator_switch > mozilla-b2g:master

Fred - Going to start working my way through the last switch controls in the settings app and porting them over. Some of the implementations were pretty tricky, so I think maybe one panel at a time might be best for implementation/review purposes, but I'll try to not overload you in reviews.

Thanks for taking a look!
Attachment #8651426 - Flags: review?(gasolin)

Comment 5

2 years ago
Comment on attachment 8651426 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_convert_network_operator_switch > mozilla-b2g:master

Yeah there are some tricky part to support switch. Thanks for make it happen.

The patch works well on device.
Please make sure the related test are all green before landing.
Attachment #8651426 - Flags: review?(gasolin) → review+
(Assignee)

Comment 6

2 years ago
Thanks. Network operator switch update checked in: https://github.com/mozilla-b2g/gaia/commit/0894b1d9d40a11ce74e77971bbfdb3a5674d3da7

Comment 7

2 years ago
Created attachment 8652153 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_simpin_panel_switch > mozilla-b2g:master

Comment 8

2 years ago
please neglect USB storage switch at root panel, since that switch (and the special split case) will be removed and moved into its sub panel. we'll refresh the UI at bug 1194045
Depends on: 1194045
(Assignee)

Comment 9

2 years ago
(In reply to Fred Lin [:gasolin] from comment #8)
> please neglect USB storage switch at root panel, since that switch (and the
> special split case) will be removed and moved into its sub panel. we'll
> refresh the UI at bug 1194045

Great, thank you for the info!
(Assignee)

Comment 10

2 years ago
Comment on attachment 8652153 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_simpin_panel_switch > mozilla-b2g:master

Fred - please take a look at this when you get a chance. Thanks!
Attachment #8652153 - Flags: review?(gasolin)

Comment 11

2 years ago
Created attachment 8656384 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_findmydevice_switch > mozilla-b2g:master

Comment 12

2 years ago
Comment on attachment 8652153 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_simpin_panel_switch > mozilla-b2g:master

Thanks kevin for fixing these hard work. 

I leave some comment in github, let's discuss if there's some room to improve the implementation.

BTW, I suggest put these PR to separate issues so QA can test them as soon as possible when we resolve the issue.
Attachment #8652153 - Flags: review?(gasolin)
(Assignee)

Comment 13

2 years ago
(In reply to Fred Lin [:gasolin] from comment #12)
> Comment on attachment 8652153 [details] [review]
> [gaia] KevinGrandon:bug_1172349_settings_simpin_panel_switch >
> mozilla-b2g:master
> 
> Thanks kevin for fixing these hard work. 
> 
> I leave some comment in github, let's discuss if there's some room to
> improve the implementation.

Thanks, I will address these.

> BTW, I suggest put these PR to separate issues so QA can test them as soon
> as possible when we resolve the issue.

Sure, let's track future work in different bugs if that's easier.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Attachment #8652153 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8656384 - Attachment is obsolete: true

Comment 14

2 years ago
Created attachment 8657485 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_findmydevice_switch > mozilla-b2g:master

Comment 15

2 years ago
Created attachment 8678533 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_remaining_switches > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8657485 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8651426 - Attachment is obsolete: true
(Assignee)

Comment 16

2 years ago
Comment on attachment 8678533 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_remaining_switches > mozilla-b2g:master

Fred - can you take a look when you get a chance? I think we are done with switches after this. Thanks for working with me on this!
Attachment #8678533 - Flags: review?(gasolin)
(Assignee)

Comment 17

2 years ago
(Oops - I already had a PR open for this, but it was closed. Just going to re-open it for now as the bug better suits the current work).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 18

2 years ago
Comment on attachment 8678533 [details] [review]
[gaia] KevinGrandon:bug_1172349_settings_remaining_switches > mozilla-b2g:master

Looks good, just need fix some gij issues.

Thanks kevin for help improving the overall settings CSS maintainance!
Attachment #8678533 - Flags: review?(gasolin) → review+
(Assignee)

Comment 19

2 years ago
Thanks for the review! Glad to be done with this one. In master: https://github.com/mozilla-b2g/gaia/commit/1efeb738fe3abe385c7ff8f9724df3a0fa706f6d
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Blocks: 1181023
Depends on: 1219619

Updated

2 years ago
Depends on: 1219378
You need to log in before you can comment on or make changes to this bug.