1194045 - [Flame][settings]USB protocol can only be changed while USB storage is disabled.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eden Chuang[:edenchuang]]

According to but 1142450 comment 16, USB protocol can only be changed while USB storage is disabled.

Comment 1

[Eden Chuang[:edenchuang]]

Hello Fred

Can you help on this spec change on setting app?

Comment 2

[[e-mail]]

[Blocking Requested - why for this release]: spec change

Comment 3

[[e-mail]]

Harly, could you help find the right person to provide update UI spec?

The main issue might be

* what the proper UI should be shown when USB disabled. (just make the left side panel not clickable when USB disabled?)

Comment 4

[[e-mail]]

per offline discussion with harly, the UI will looks like wifi panel:

1. the USB storage switch is moving into the panel. Above with origin protocol selection checkboxes.
2. add an attribute for device customization.
2.1 if the device support switch storage in enabled mode, let protocol selection enabled
2.2 if the device does not support switch storage in enabled mode, only enable protocol selection when USB storage switch off

We can start implementation and set UI review.
Harly will find people to come out the UI spec when they have time.

Comment 5

[Harly Hsu[:harly]]

Attachment: [Settings] USB Transfer Protocol_v1.0.pdf

Attaching the spec for the USB transfer protocol as described by Fred. Feel free to comment if there is any concerns.

Comment 6

[[e-mail]]

Attachment: removed switch from usb storage panel

the panel mockup (code may not functional)

Comment 7

[[e-mail]]

Attachment: usb storage panel

the usb storage panel mockup (code may not functional)

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1194045 > mozilla-b2g:master

Comment 9

[[e-mail]]

Will add `usbHotProtocolSwitch` in device-features.json to determine if we support switch protocol when ums enabled

Need update MDN when the patch is landed
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide

Comment 10

[[e-mail]]

Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Since its a relative big UI change, set 2 reviewers to make sure I did not left things.

also set UI review to Harly.

Comment 12

[[e-mail]]

Talked with Harly & Eden, the UI spec will be appended to:

* Show same ums description as in root panel to indicate current ums state.
* Disable the protocol selection when:
1. ums enabled & device plugged
2. usm enabled then disabled but device is still plugged

I can implement the appended spec as followup or in this patch due to the review status.

Comment 13

[[e-mail]]

After checking code I think its better to separate Comment 12 effort in another issue.

We need refactor MediaVolume related function into module first before support above changes.

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Looks good, left some feedback in Github, thanks Fred!

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

sorry switched the wrong flag.

Comment 16

[Harly Hsu[:harly]]

Attachment: [Settings] USB Transfer Protocol_v1.1.pdf

Updated spec based on offline discussion with Fred and Eden.

Comment 17

[Evelyn Hung]

Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Thanks for your offline explanation, that helps me to understand the key part of this patch. Please write a summary of changes in your review request next time, thank you. :)

Comment 18

[[e-mail]]

Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

will set ui review to harly again in followup bug

Comment 19

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/11380b7fc6390a20a5f1446ff13e8cb0941e22fa

thanks!

Comment 20

[[e-mail]]

MDN updated
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide