Closed Bug 1194045 Opened 4 years ago Closed 4 years ago

[Flame][settings]USB protocol can only be changed while USB storage is disabled.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.5+)

RESOLVED FIXED
FxOS-S9 (16Oct)
blocking-b2g 2.5+

People

(Reporter: edenchuang, Assigned: gasolin)

References

Details

Attachments

(4 files, 1 obsolete file)

According to but 1142450 comment 16, USB protocol can only be changed while USB storage is disabled.
Hello Fred

Can you help on this spec change on setting app?
Flags: needinfo?(gasolin)
Blocks: 1142450
Assignee: nobody → gasolin
Flags: needinfo?(gasolin)
[Blocking Requested - why for this release]: spec change
blocking-b2g: --- → 2.5?
Component: MTP/UMS → Gaia::Settings
Harly, could you help find the right person to provide update UI spec?

The main issue might be

* what the proper UI should be shown when USB disabled. (just make the left side panel not clickable when USB disabled?)
Flags: needinfo?(hhsu)
blocking-b2g: 2.5? → 2.5+
Target Milestone: --- → FxOS-S9 (16Oct)
No longer blocks: 1142450
Depends on: 1142450
per offline discussion with harly, the UI will looks like wifi panel:

1. the USB storage switch is moving into the panel. Above with origin protocol selection checkboxes.
2. add an attribute for device customization.
2.1 if the device support switch storage in enabled mode, let protocol selection enabled
2.2 if the device does not support switch storage in enabled mode, only enable protocol selection when USB storage switch off

We can start implementation and set UI review.
Harly will find people to come out the UI spec when they have time.
Blocks: 1172349
Attaching the spec for the USB transfer protocol as described by Fred. Feel free to comment if there is any concerns.
Flags: needinfo?(hhsu)
the panel mockup (code may not functional)
Attached image usb storage panel
the usb storage panel mockup (code may not functional)
Blocks: 1189679
Status: NEW → ASSIGNED
Blocks: 1181023
Depends on: 1202357
Will add `usbHotProtocolSwitch` in device-features.json to determine if we support switch protocol when ums enabled

Need update MDN when the patch is landed
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide
Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Since its a relative big UI change, set 2 reviewers to make sure I did not left things.

also set UI review to Harly.
Attachment #8655328 - Flags: ui-review?(hhsu)
Attachment #8655328 - Flags: review?(yzenevich)
Attachment #8655328 - Flags: review?(ehung)
Duplicate of this bug: 1142450
Talked with Harly & Eden, the UI spec will be appended to:

* Show same ums description as in root panel to indicate current ums state.
* Disable the protocol selection when:
1. ums enabled & device plugged
2. usm enabled then disabled but device is still plugged

I can implement the appended spec as followup or in this patch due to the review status.
See Also: → 1203461
After checking code I think its better to separate Comment 12 effort in another issue.

We need refactor MediaVolume related function into module first before support above changes.
Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Looks good, left some feedback in Github, thanks Fred!
Attachment #8655328 - Flags: ui-review?(hhsu) → ui-review+
Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

sorry switched the wrong flag.
Attachment #8655328 - Flags: ui-review?(hhsu)
Attachment #8655328 - Flags: ui-review+
Attachment #8655328 - Flags: review?(yzenevich)
Attachment #8655328 - Flags: review+
Updated spec based on offline discussion with Fred and Eden.
Attachment #8653960 - Attachment is obsolete: true
Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

Thanks for your offline explanation, that helps me to understand the key part of this patch. Please write a summary of changes in your review request next time, thank you. :)
Attachment #8655328 - Flags: review?(ehung) → review+
Comment on attachment 8655328 [details] [review]
[gaia] gasolin:issue-1194045 > mozilla-b2g:master

will set ui review to harly again in followup bug
Attachment #8655328 - Flags: ui-review?(hhsu)
merged https://github.com/mozilla-b2g/gaia/commit/11380b7fc6390a20a5f1446ff13e8cb0941e22fa

thanks!
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1206384
Blocks: 1212235
You need to log in before you can comment on or make changes to this bug.