Fix and re-enable test_privbrowsing_perwindowpb.html

NEW
Unassigned

Status

()

Toolkit
Password Manager
3 years ago
2 years ago

People

(Reporter: RyanVM, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [passwords:tech-debt])

(Reporter)

Description

3 years ago
test_privbrowsing_perwindowpb.html was originally disabled in bug 919016. However, that test became a dumping ground for different issues. Per a recent Try push, this test is still severely broken across all platforms.

Opt builds continue to hit the failure mode described in bug 919016:
https://treeherder.mozilla.org/logviewer.html#?job_id=8353124&repo=try

2616 INFO TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | Checking submitted password - got , expected notifyp1

Debug builds are also susceptible to the failures above. Additionally, they also frequently hit asserts and crashes:
https://treeherder.mozilla.org/logviewer.html#?job_id=8353022&repo=try

Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /builds/slave/try-lx-d-000000000000000000000/build/src/toolkit/components/autocomplete/nsAutoCompleteController.cpp:771
PROCESS-CRASH | toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | application crashed [@ nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*)]
Whiteboard: [passwords:tech-debt]
You need to log in before you can comment on or make changes to this bug.