1173695 - Unable to import specific profiles which cause an error to be thrown by recording-utils.js:303:6

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Andrei Vaida [:avaida]]

Attachment: profile

NOTE: this is a follow-up issue from Bug 1164130.

Reproducible on:
* Aurora 40.0a2 (2015-06-10)
* Nightly 41.0a1 (2015-06-10)

Affected platforms:
Windows 7 (x64), Mac OS X 10.9.5 and Ubuntu 14.04 (x64)

Steps to reproduce:
1. Launch Firefox.
2. Open the Performance tools.
3. Import the attached profile.
4. Check the Browser Console.

Expected result:
* The profile is successfully imported.
* There are no errors thrown in the Browser Console for this action.

Actual result:
The profile cannot be imported and the following error gets thrown in the Browser Console by recording-utils.js:303:6:
> TypeError: samples is undefined

Additional notes:
* This is the only profile sample I have that reproduces the issue, I'm not sure what went wrong but trying to import a 2nd profile made from the same browser version (Release 37.0.2) was successful.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1173695-import-failure.patch

Not sure what causes this. But this recording is a v2 recording, and also has deflated profiler data. An extra thread is a string, and contains additional threads, like it's a full other recording. Anyways, this protects against that

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8621399 [details] [diff] [review]
1173695-import-failure.patch

Review of attachment 8621399 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/logic/recording-utils.js
@@ +259,5 @@
>   */
>  function deflateProfile(profile) {
>    profile.threads = profile.threads.map((thread) => {
>      let uniqueStacks = new UniqueStacks();
> +

Nit: useless newline.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/10f378449181

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/10f378449181

Comment 5

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 41.0a1 (2015-06-23), using Windows 8.1 (x64), Ubuntu 14.04 (x86) and Mac OS X 10.9.5.