1164130 - [regression] Importing profiler v2 fails as RecordingUtils not included in io.js

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

via Bug 1154115

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1164130-fix-import.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=230e2a2743a5

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8604858 [details] [diff] [review]
1164130-fix-import.patch

Review of attachment 8604858 [details] [diff] [review]:
-----------------------------------------------------------------

amaze

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/32ad078a4b5f

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/7f901174dd44
remote:   https://hg.mozilla.org/integration/fx-team/rev/32ad078a4b5f
remote:   https://hg.mozilla.org/integration/fx-team/rev/914dda9f4a1a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32ad078a4b5f

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

ni? jsantell for STR

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

STR: Import a profile (version 2) in the new performance tool. (To create a profile of this version, use Firefox 39 or below and record a profile, and save that).

Expected Results: Profile loads correctly, no errors thrown, and the call tree and framerate graphs are displayed.

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8604858 [details] [diff] [review]
1164130-fix-import.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 10

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b361f39e79d5

Comment 11

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8604858 [details] [diff] [review]
1164130-fix-import.patch

Change approved to skip one train as part of the spring campaign.

Comment 13

[Andrei Vaida [:avaida]]

With the exception of Bug 1173695, this is verified fixed on on Aurora 40.0a2 (2015-06-10), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

The user is able to successfully import v2 profiles in the new Performance tool, which will only display the "Call Tree" and "Flame Chart" detailed views for them. Tested with Nightly 39.0a1 (2015-03-22) and Release 37.0.2.