Closed Bug 1173736 Opened 5 years ago Closed 4 years ago

Increase URL and search bar height and text size on Windows 10

Categories

(Firefox :: Theme, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: dao, Assigned: shorlander)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

http://people.mozilla.org/~shorlander/mockups/Windows-10/Windows-10.html says the text size should be 16px (needs to be translated to em) and the box height should be 28px.
Assignee: nobody → dao
Status: NEW → ASSIGNED
This increases the font-size and height of the location and search fields. I cleaned up the existing clip-path but I also had to make an additional one to accommodate the increased height.
Attachment #8626943 - Flags: review?(dao)
Comment on attachment 8626943 [details] [diff] [review]
increase-height-of-locationBar.patch

Thanks!

It will look slightly weird that hovered toolbar buttons are smaller than the location and search bars, but we can take care of that in bug 1173743.
Attachment #8626943 - Flags: review?(dao) → review+
Assignee: dao → shorlander
https://hg.mozilla.org/mozilla-central/rev/c9a6fe3629ae
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8626943 [details] [diff] [review]
increase-height-of-locationBar.patch

Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: low. regressions, if any, should be minor
[String/UUID change made/needed]: none
Attachment #8626943 - Flags: approval-mozilla-beta?
Depends on: 1179295
The URL and search bar height was properly increased to 28px.

Filled bug 1179768 for the text, which is only 13px.
Status: RESOLVED → VERIFIED
No longer depends on: 1179768
Comment on attachment 8626943 [details] [diff] [review]
increase-height-of-locationBar.patch

Visual fix for Windows 10. Been on m-c for a week. Beta+
Attachment #8626943 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
The URL and search bar height is now increased to 28px on Firefox 40 beta 2 (build ID: 20150706172413) too.
QA Contact: cornel.ionce
Depends on: 1184728
Blocks: 1186562
No longer depends on: 1186562
You need to log in before you can comment on or make changes to this bug.