Closed
Bug 1173736
Opened 9 years ago
Closed 9 years ago
Increase URL and search bar height and text size on Windows 10
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 41
People
(Reporter: dao, Assigned: shorlander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.41 KB,
patch
|
dao
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
http://people.mozilla.org/~shorlander/mockups/Windows-10/Windows-10.html says the text size should be 16px (needs to be translated to em) and the box height should be 28px.
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → dao
Status: NEW → ASSIGNED
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•9 years ago
|
||
This increases the font-size and height of the location and search fields. I cleaned up the existing clip-path but I also had to make an additional one to accommodate the increased height.
Attachment #8626943 -
Flags: review?(dao)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8626943 [details] [diff] [review] increase-height-of-locationBar.patch Thanks! It will look slightly weird that hovered toolbar buttons are smaller than the location and search bars, but we can take care of that in bug 1173743.
Attachment #8626943 -
Flags: review?(dao) → review+
Reporter | ||
Updated•9 years ago
|
Assignee: dao → shorlander
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9a6fe3629ae
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8626943 [details] [diff] [review] increase-height-of-locationBar.patch Approval Request Comment [Feature/regressing bug #]: Windows 10 [User impact if declined]: [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: low. regressions, if any, should be minor [String/UUID change made/needed]: none
Attachment #8626943 -
Flags: approval-mozilla-beta?
Comment 6•9 years ago
|
||
The URL and search bar height was properly increased to 28px. Filled bug 1179768 for the text, which is only 13px.
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 7•9 years ago
|
||
Comment on attachment 8626943 [details] [diff] [review] increase-height-of-locationBar.patch Visual fix for Windows 10. Been on m-c for a week. Beta+
Attachment #8626943 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Flags: qe-verify+
Comment 9•9 years ago
|
||
The URL and search bar height is now increased to 28px on Firefox 40 beta 2 (build ID: 20150706172413) too.
QA Contact: cornel.ionce
Reporter | ||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•