Closed Bug 1173739 Opened 9 years ago Closed 9 years ago

Update history dropdown and Reload/Stop/Go icons on Windows 10

Categories

(Firefox :: Theme, defect, P2)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(9 files)

      No description provided.
needinfo for the icons
Flags: needinfo?(shorlander)
Summary: Update history dropdown and Reload/Stop/Go icons on Windows 10 → Update history dropdown, Reload/Stop/Go and Search bar search glass icons on Windows 10
Priority: -- → P1
Dropdown icon like the one on the taskbar?
Flags: needinfo?(shorlander)
Assignee: nobody → dao
Assignee: dao → nobody
Priority: P1 → P2
Assignee: nobody → dao
Turns out we currently use the same icon on all OSes. Having one icon for Windows 10 only and another one shared for all the rest (that's other Windows versions, Linux and OS X) seems weird. Spinning this off to bug 1173739.
Summary: Update history dropdown, Reload/Stop/Go and Search bar search glass icons on Windows 10 → Update history dropdown and Reload/Stop/Go icons on Windows 10
Attached patch patchSplinter Review
Attachment #8635700 - Flags: review?(jaws)
Comment on attachment 8635700 [details] [diff] [review]
patch

Makes sense to me to use the new asset for Windows 8 as well. The old glow doesn't really fit into the Windows 8 experience either.
I don't have a strong opinion about whether we should use these images on Windows 8. I don't think it makes a big difference.
Attachment #8635700 - Flags: review?(jaws) → review+
Please file a new bug if you still think we should use the new icons on Windows 8.
Blocks: 1185606
https://hg.mozilla.org/mozilla-central/rev/1009c4ac8efb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Flags: qe-verify+
Comment on attachment 8635700 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: just an image drop, low risk
[String/UUID change made/needed]: none
Attachment #8635700 - Flags: approval-mozilla-beta?
Attachment #8635700 - Flags: approval-mozilla-aurora?
Comment on attachment 8635700 [details] [diff] [review]
patch

Beta+ Aurora+
Attachment #8635700 - Flags: approval-mozilla-beta?
Attachment #8635700 - Flags: approval-mozilla-beta+
Attachment #8635700 - Flags: approval-mozilla-aurora?
Attachment #8635700 - Flags: approval-mozilla-aurora+
QA Contact: cornel.ionce
The icons are now changed but a small glow can still be noticed on hover/click. Filled bug 1188332 as a follow up.

Tested on Windows 10 64-bit using:
- Nightly 42.0a1, build ID: 20150727030216;
- Aurora 41.0a2, build ID: 20150727004009;
- Firefox 40.0b8, build ID: 20150727174134.
Status: RESOLVED → VERIFIED
Depends on: 1188332
Depends on: 1186687
You need to log in before you can comment on or make changes to this bug.