1186687 - Remove hover glow behind urlbar icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Comment 1

[Tim Nguyen :ntim]

STR :
- Hover the urlbar icons
- See the colorful glow behind them

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

The glow doesn't seem native on any platform, so I removed it across the board. The affected icons generally already provide dedicated hover/active states except for Info.png on Linux.

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 8646208 [details] [diff] [review]
patch

Review of attachment 8646208 [details] [diff] [review]:
-----------------------------------------------------------------

Removing it on all platforms works for me.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5b91bffd15e3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b91bffd15e3

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8646208 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: motivated by Windows 10, but this is a cross-platform change
[User impact if declined]: just aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: only code removal, not risky
[String/UUID change made/needed]: none

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8646208 [details] [diff] [review]
patch

Code changes like these (aesthetics) should ideally ride the trains rather than getting uplifted to Beta directly unless there is a specific compete/compliance push or a stronger justification. 

The end-user impact in this case does not warrant an uplift to Beta. Let's uplift to Aurora only.

Comment 9

[Dão Gottwald [:dao]]

Not uplifting to beta will make it harder to uplift related changes, i.e. bug 1185960 in this case. Both this and that other bug were marked as blocking bug 1192839, so I think there's a specific push from a UX perspective.

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

The hover glow is now properly removed using latest Nightly 43.0a1, build ID: 20150813030208.

Tested on Windows 7 64-bit, Windows 8.1 32-bit, Windows 10 64-bit, Ubuntu 12.04 32bit and Mac OS X 10.9.5.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ffddd1f9cf27

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8646208 [details] [diff] [review]
patch

I was told that this might be part of the improvements for win10 support in FF41 umbrella. Given that, approving for uplift to Beta.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a473235459fd

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Also confirming the fix on Windows 7 64-bit, Windows 10 64-bit, Ubuntu 12.04 32bit and Mac OS X 10.9.5 using:
* latest Aurora, build ID: 20150817004010
* Firefox 41.0b2, build ID: 20150817163452.