Remove hover glow behind urlbar icons

VERIFIED FIXED in Firefox 41

Status

()

Firefox
Theme
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: ntim, Assigned: dao)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 43
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox41 verified, firefox42 verified, firefox43 verified)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Summary: Remove glow behind urlbar icons on Windows 8 and 10 → Remove hover glow behind urlbar icons on Windows 8 and 10
(Reporter)

Comment 1

2 years ago
STR :
- Hover the urlbar icons
- See the colorful glow behind them
(Reporter)

Updated

2 years ago
Blocks: 1158143
No longer blocks: 1077146
Duplicate of this bug: 1188332
Blocks: 1173739
Blocks: 1192839
(Assignee)

Comment 3

2 years ago
Created attachment 8646208 [details] [diff] [review]
patch

The glow doesn't seem native on any platform, so I removed it across the board. The affected icons generally already provide dedicated hover/active states except for Info.png on Linux.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8646208 - Flags: ui-review?(philipp)
Attachment #8646208 - Flags: review?(jaws)
Comment on attachment 8646208 [details] [diff] [review]
patch

Review of attachment 8646208 [details] [diff] [review]:
-----------------------------------------------------------------

Removing it on all platforms works for me.
Attachment #8646208 - Flags: ui-review?(philipp) → ui-review+
Attachment #8646208 - Flags: review?(jaws) → review+
(Assignee)

Updated

2 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Remove hover glow behind urlbar icons on Windows 8 and 10 → Remove hover glow behind urlbar icons

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/5b91bffd15e3
https://hg.mozilla.org/mozilla-central/rev/5b91bffd15e3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
(Assignee)

Updated

2 years ago
Flags: qe-verify+
(Assignee)

Comment 7

2 years ago
Comment on attachment 8646208 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: motivated by Windows 10, but this is a cross-platform change
[User impact if declined]: just aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: only code removal, not risky
[String/UUID change made/needed]: none
Attachment #8646208 - Flags: approval-mozilla-beta?
Attachment #8646208 - Flags: approval-mozilla-aurora?

Comment 8

2 years ago
Comment on attachment 8646208 [details] [diff] [review]
patch

Code changes like these (aesthetics) should ideally ride the trains rather than getting uplifted to Beta directly unless there is a specific compete/compliance push or a stronger justification. 

The end-user impact in this case does not warrant an uplift to Beta. Let's uplift to Aurora only.
Attachment #8646208 - Flags: approval-mozilla-beta?
Attachment #8646208 - Flags: approval-mozilla-beta-
Attachment #8646208 - Flags: approval-mozilla-aurora?
Attachment #8646208 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 9

2 years ago
Not uplifting to beta will make it harder to uplift related changes, i.e. bug 1185960 in this case. Both this and that other bug were marked as blocking bug 1192839, so I think there's a specific push from a UX perspective.
Flags: needinfo?(rkothari)
Flags: needinfo?(philipp)
The hover glow is now properly removed using latest Nightly 43.0a1, build ID: 20150813030208.

Tested on Windows 7 64-bit, Windows 8.1 32-bit, Windows 10 64-bit, Ubuntu 12.04 32bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox43: fixed → verified
QA Contact: cornel.ionce
https://hg.mozilla.org/releases/mozilla-aurora/rev/ffddd1f9cf27
status-firefox42: --- → fixed

Updated

2 years ago
status-firefox41: --- → affected
Flags: needinfo?(rkothari)
Comment on attachment 8646208 [details] [diff] [review]
patch

I was told that this might be part of the improvements for win10 support in FF41 umbrella. Given that, approving for uplift to Beta.
Attachment #8646208 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
(Assignee)

Updated

2 years ago
Flags: needinfo?(philipp)
https://hg.mozilla.org/releases/mozilla-beta/rev/a473235459fd
status-firefox41: affected → fixed
Also confirming the fix on Windows 7 64-bit, Windows 10 64-bit, Ubuntu 12.04 32bit and Mac OS X 10.9.5 using:
* latest Aurora, build ID: 20150817004010
* Firefox 41.0b2, build ID: 20150817163452.
status-firefox41: fixed → verified
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.