Closed
Bug 1174574
Opened 9 years ago
Closed 9 years ago
[css-grid] Implement intrinsic sizing for grid containers (aka GetMinISize/GetPrefISize)
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
|
8.06 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
8.06 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•9 years ago
|
||
This is just a bit of refactoring, as I hinted at bug 1151212. (You might think that "why not move the Initialize calls too?" but bug 1174569 will likely add more code between these steps, so I think I'll leave it as is for now.) https://treeherder.mozilla.org/#/jobs?repo=try&author=mpalmgren@mozilla.com
Attachment #8625323 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f889127c20d3
Attachment #8625324 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 3•9 years ago
|
||
A minor param name tweak. FYI, these patches are not really dependent on earlier patches for review.
Attachment #8625323 -
Attachment is obsolete: true
Attachment #8625323 -
Flags: review?(dholbert)
Attachment #8647740 -
Flags: review?(dholbert)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8647740 [details] [diff] [review] part 1 - [css-grid] Move the guts of nsGridContainerFrame::CalculateTrackSizes into a Tracks method Part 1 seems like an equivalent transformation (a legit refactoring); r=me
Attachment #8647740 -
Flags: review?(dholbert) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8625324 [details] [diff] [review] part 2 - [css-grid] Implement intrinsic sizing for grid containers (aka GetMinISize/GetPrefISize) Review of attachment 8625324 [details] [diff] [review]: ----------------------------------------------------------------- r=me on part 2
Attachment #8625324 -
Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/16cf05b1664c https://hg.mozilla.org/integration/mozilla-inbound/rev/fd3a53075e54
Backed out for reftest bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=13722584&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4eff0977f2 https://hg.mozilla.org/integration/mozilla-inbound/rev/dcc2e7019aa2
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5ad7ef6a43 https://hg.mozilla.org/integration/mozilla-inbound/rev/bacad119cc26
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf5ad7ef6a43 https://hg.mozilla.org/mozilla-central/rev/bacad119cc26
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•