Closed Bug 1174574 Opened 5 years ago Closed 5 years ago

[css-grid] Implement intrinsic sizing for grid containers (aka GetMinISize/GetPrefISize)

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox41 --- affected
firefox43 --- fixed

People

(Reporter: mats, Assigned: mats)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

This is just a bit of refactoring, as I hinted at bug 1151212.

(You might think that "why not move the Initialize calls too?"
but bug 1174569 will likely add more code between these steps,
so I think I'll leave it as is for now.)

https://treeherder.mozilla.org/#/jobs?repo=try&author=mpalmgren@mozilla.com
Attachment #8625323 - Flags: review?(dholbert)
Blocks: 1000592
Blocks: 1194446
A minor param name tweak.

FYI, these patches are not really dependent on earlier patches for review.
Attachment #8625323 - Attachment is obsolete: true
Attachment #8625323 - Flags: review?(dholbert)
Attachment #8647740 - Flags: review?(dholbert)
Comment on attachment 8647740 [details] [diff] [review]
part 1 - [css-grid] Move the guts of nsGridContainerFrame::CalculateTrackSizes into a Tracks method

Part 1 seems like an equivalent transformation (a legit refactoring); r=me
Attachment #8647740 - Flags: review?(dholbert) → review+
Comment on attachment 8625324 [details] [diff] [review]
part 2 - [css-grid] Implement intrinsic sizing for grid containers (aka GetMinISize/GetPrefISize)

Review of attachment 8625324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on part 2
Attachment #8625324 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/cf5ad7ef6a43
https://hg.mozilla.org/mozilla-central/rev/bacad119cc26
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.