1000592 - Enable CSS Grid by default in non-release channels

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Mats Palmgren (inactive)]

Attachment: fix

+++ This bug was initially created as a clone of Bug #1000431 +++

At the same time we should also remove:
https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

All the listed blocking bugs now have patches (some still pending review).
So I think we're ready to enable Grid in Nightly and Developer Edition builds,
as soon as those lands.

Comment 2

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6078c45e70cd

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Mats Palmgren (:mats) from comment #0)
> At the same time we should also remove:
> https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js

Note: the patch is missing this suggested testing/profiles/prefs_general.js tweak. But I think that's correct, because we'll still need this line for release builds (or else tests would start failing there when this bug's patch got merged to a RELEASE_BUILD).

Comment 4

[Mats Palmgren (inactive)]

I think we can (and should) remove that bit from the testing profile actually.
Why would tests start failing without it?

Comment 5

[Daniel Holbert [:dholbert]]

Sorry, I should've said "might start failing" (if we have tests that assume grid is enabled -- which we could have, but maybe/probably we don't)

r=me with the testing profile tweak added, as long as you've verified that tests pass with that (and without the all.js pref-flip).  

(Might really be better to land the testing profile tweak first, as its own patch, so that we get a full TreeHerder cycle with the test-profile pref-enabled configuration that we'll end up having on Release.  But I suppose a Try run of just that tweak would do too.)

Comment 6

[Mats Palmgren (inactive)]

Actually, it's probably better to leave that as is so that we have test coverage
for Grid on those channels too, even though it's not enabled by default (the Grid
test manifest enables it unconditionally for those tests at least).

We can remove it at the same time we let it ride the trains.
I filed bug 1217086 and made a note there so we don't forget.

Comment 7

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/282e4426f1e1

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/282e4426f1e1

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/282e4426f1e1

Comment 10

[Carsten Book [:Tomcat]]

(In reply to Carsten Book [:Tomcat] from comment #9)
> https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/282e4426f1e1

backed this out on request from mats from b2g v2.5 in http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0869ace8c965