Closed Bug 1000592 Opened 5 years ago Closed 4 years ago

Enable CSS Grid by default in non-release channels

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: mats, Assigned: mats)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #1000431 +++

At the same time we should also remove:
https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js
Summary: Enable "layout.css.grid.enabled" by default in non-release channels → Enable CSS Grid by default in non-release channels
Depends on: 1176775
Depends on: 1174574
Depends on: 1151214
Depends on: 1151213
Assignee: nobody → mats
Depends on: 1194888
Depends on: 1194892
Depends on: 1215182
Depends on: 1215957
Depends on: 1211260
Attached patch fixSplinter Review
All the listed blocking bugs now have patches (some still pending review).
So I think we're ready to enable Grid in Nightly and Developer Edition builds,
as soon as those lands.
Attachment #8411417 - Attachment is obsolete: true
Attachment #8675730 - Flags: review?(dholbert)
(In reply to Mats Palmgren (:mats) from comment #0)
> At the same time we should also remove:
> https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js

Note: the patch is missing this suggested testing/profiles/prefs_general.js tweak. But I think that's correct, because we'll still need this line for release builds (or else tests would start failing there when this bug's patch got merged to a RELEASE_BUILD).
Attachment #8675730 - Flags: review?(dholbert) → review+
I think we can (and should) remove that bit from the testing profile actually.
Why would tests start failing without it?
Flags: needinfo?(dholbert)
Sorry, I should've said "might start failing" (if we have tests that assume grid is enabled -- which we could have, but maybe/probably we don't)

r=me with the testing profile tweak added, as long as you've verified that tests pass with that (and without the all.js pref-flip).  

(Might really be better to land the testing profile tweak first, as its own patch, so that we get a full TreeHerder cycle with the test-profile pref-enabled configuration that we'll end up having on Release.  But I suppose a Try run of just that tweak would do too.)
Flags: needinfo?(dholbert)
Actually, it's probably better to leave that as is so that we have test coverage
for Grid on those channels too, even though it's not enabled by default (the Grid
test manifest enables it unconditionally for those tests at least).

We can remove it at the same time we let it ride the trains.
I filed bug 1217086 and made a note there so we don't forget.
Depends on: 1163565
Depends on: 1163435
https://hg.mozilla.org/mozilla-central/rev/282e4426f1e1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.