1175455 - Eliminate FB toggle in Contacts Settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

As first step as part of the Meta Bug 1173013 that removes current FB integration from Contacts, we need to eliminate FaceBook synchronization toggle from Contacts Setting.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8623625 [details] [review]
Pull Request

Left some comments in gh. No blockers to land this, but definitely questions and thoughs on how we should move forward.

Thanks Borja

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/9724af922353f5700ba7649b134878d75d2b0ae2

Comment 4

[Annabelle]

This bug has been verified as pass on latest build of Flame v2.5 and Aries v2.5 by the followling steps.

Steps:
1) Launch "Contacts" app.
2) Tap the gear icon at the top right corner. 

Actual results: The function that FaceBook synchronization toggle is eliminated from Contacts Setting.
See attachment: Verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Aries KK 2.5(Pass)
Build ID               20150913195924
Gaia Revision          4d9b996be4b1935651057d0651461c1a36d98a18
Gaia Date              2015-09-13 10:47:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150913.192006
Firmware Date          Sun Sep 13 19:20:14 UTC 2015
Bootloader             s1

Device: Flame KK 2.5(Pass)
Build ID               20150913150208
Gaia Revision          4d9b996be4b1935651057d0651461c1a36d98a18
Gaia Date              2015-09-13 10:47:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150913.184300
Firmware Date          Sun Sep 13 18:43:14 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 5

[Annabelle]

Attachment: Verified_Aries_v2.5.png