1175650 - Create JIT details view

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1175650-jit-view.patch

Some small test failures, but wanted to get this out sooner than later

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1175650-jit-view.patch

updated with working tests

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bebc60cf5759

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8624468 [details] [diff] [review]
1175650-jit-view.patch

Review of attachment 8624468 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/performance.xul
@@ +342,5 @@
> +                  <tabs>
> +                    <tab id="optimizations-optimizations-tab"
> +                         label="Optimizations" />
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />

Localize?

@@ +345,5 @@
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />
> +                  </tabs>
> +                  <tabpanels flex="1">
> +                    <!-- Optimizations Panel -->

Nit: Add an newline before this comment to make it parsing this xul file easier on the eyes

@@ +360,5 @@
> +                        </toolbar>
> +                        <vbox id="jit-optimizations-raw-view"></vbox>
> +                      </vbox>
> +                    </tabpanel>
> +                    <tabpanel id="frames-tabpanel"

<-- Frames Panel --> comment goes here. Newline before

::: browser/devtools/performance/views/details-optimizations.js
@@ +23,5 @@
> +
> +    OptimizationsListView.initialize();
> +    FramesListView.initialize({ container: $("#frames-tabpanel") });
> +    FramesListView.on("select", this._onFramesListSelect);
> +    //PerformanceController.on(EVENTS.RECORDING_SELECTED, this.reset);

Commented out code?

@@ +35,5 @@
> +
> +    this.tabs = this._threadNode = this._frameNode = null;
> +    OptimizationsListView.destroy();
> +    FramesListView.destroy();
> +    DetailsSubview.destroy.call(this);

This should be the first method called.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8624468 [details] [diff] [review]
1175650-jit-view.patch

Review of attachment 8624468 [details] [diff] [review]:
-----------------------------------------------------------------

Fixin' it up

::: browser/devtools/performance/performance.xul
@@ +342,5 @@
> +                  <tabs>
> +                    <tab id="optimizations-optimizations-tab"
> +                         label="Optimizations" />
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />

Want to hold off on localizing too much as I'd imagine we'll be changing a lot of names here for the prototype

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2fe76a95986b
https://hg.mozilla.org/integration/fx-team/rev/c3100b5ccfe8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2fe76a95986b
https://hg.mozilla.org/mozilla-central/rev/c3100b5ccfe8