Closed Bug 1175650 Opened 5 years ago Closed 5 years ago

Create JIT details view

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 1150299, 1174267
No longer depends on: 1150299
Depends on: 1175705
Attached patch 1175650-jit-view.patch (obsolete) — Splinter Review
Some small test failures, but wanted to get this out sooner than later
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8624456 - Flags: review?(vporof)
updated with working tests
Attachment #8624456 - Attachment is obsolete: true
Attachment #8624456 - Flags: review?(vporof)
Attachment #8624468 - Flags: review?(vporof)
Comment on attachment 8624468 [details] [diff] [review]
1175650-jit-view.patch

Review of attachment 8624468 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/performance.xul
@@ +342,5 @@
> +                  <tabs>
> +                    <tab id="optimizations-optimizations-tab"
> +                         label="Optimizations" />
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />

Localize?

@@ +345,5 @@
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />
> +                  </tabs>
> +                  <tabpanels flex="1">
> +                    <!-- Optimizations Panel -->

Nit: Add an newline before this comment to make it parsing this xul file easier on the eyes

@@ +360,5 @@
> +                        </toolbar>
> +                        <vbox id="jit-optimizations-raw-view"></vbox>
> +                      </vbox>
> +                    </tabpanel>
> +                    <tabpanel id="frames-tabpanel"

<-- Frames Panel --> comment goes here. Newline before

::: browser/devtools/performance/views/details-optimizations.js
@@ +23,5 @@
> +
> +    OptimizationsListView.initialize();
> +    FramesListView.initialize({ container: $("#frames-tabpanel") });
> +    FramesListView.on("select", this._onFramesListSelect);
> +    //PerformanceController.on(EVENTS.RECORDING_SELECTED, this.reset);

Commented out code?

@@ +35,5 @@
> +
> +    this.tabs = this._threadNode = this._frameNode = null;
> +    OptimizationsListView.destroy();
> +    FramesListView.destroy();
> +    DetailsSubview.destroy.call(this);

This should be the first method called.
Attachment #8624468 - Flags: review?(vporof) → review+
Comment on attachment 8624468 [details] [diff] [review]
1175650-jit-view.patch

Review of attachment 8624468 [details] [diff] [review]:
-----------------------------------------------------------------

Fixin' it up

::: browser/devtools/performance/performance.xul
@@ +342,5 @@
> +                  <tabs>
> +                    <tab id="optimizations-optimizations-tab"
> +                         label="Optimizations" />
> +                    <tab id="optimizations-frames-tab"
> +                         label="Frames" />

Want to hold off on localizing too much as I'd imagine we'll be changing a lot of names here for the prototype
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2fe76a95986b
https://hg.mozilla.org/mozilla-central/rev/c3100b5ccfe8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.