1175705 - [JIT View] "enable JIT optimizations" should be a recording feature

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

More in line with enable-allocations or enable-framerate, rather than a toggleable option, like flattening recursion. This'll save us in the future from not collecting opt data when it's not requested, not processing it, and the JIT panel will be moving away from the call tree anyway, so it won't be intrusive if enabling JIT opts anyway.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1175705-jit-opts-feature.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1b56327eff7

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8623917 [details] [diff] [review]
1175705-jit-opts-feature.patch

Review of attachment 8623917 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/logic/front.js
@@ +459,5 @@
>      withMarkers: true,
>      withMemory: Services.prefs.getBoolPref("devtools.performance.ui.enable-memory"),
>      withTicks: Services.prefs.getBoolPref("devtools.performance.ui.enable-framerate"),
>      withAllocations: Services.prefs.getBoolPref("devtools.performance.ui.enable-allocations"),
> +    withOptimizations: Services.prefs.getBoolPref("devtools.performance.ui.enable-jit-optimizations"),

withJitOptimizations would be more specific.

::: browser/devtools/performance/test/browser_perf-jit-view-01.js
@@ +18,5 @@
>    let profilerData = { threads: [gThread] }
>  
> +  is(Services.prefs.getBoolPref(JIT_PREF), false, "record JIT Optimizations pref off by default");
> +  Services.prefs.setBoolPref(JIT_PREF, true);
> +  is(Services.prefs.getBoolPref(JIT_PREF), true, "toggle on record JIT Optimizations");

you really don't need this assertion lol

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Changed to withJITOptimizations

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d479c310b3d4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d479c310b3d4