Closed Bug 1175705 Opened 4 years ago Closed 4 years ago

[JIT View] "enable JIT optimizations" should be a recording feature

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

More in line with enable-allocations or enable-framerate, rather than a toggleable option, like flattening recursion. This'll save us in the future from not collecting opt data when it's not requested, not processing it, and the JIT panel will be moving away from the call tree anyway, so it won't be intrusive if enabling JIT opts anyway.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Comment on attachment 8623917 [details] [diff] [review]
1175705-jit-opts-feature.patch

Review of attachment 8623917 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/logic/front.js
@@ +459,5 @@
>      withMarkers: true,
>      withMemory: Services.prefs.getBoolPref("devtools.performance.ui.enable-memory"),
>      withTicks: Services.prefs.getBoolPref("devtools.performance.ui.enable-framerate"),
>      withAllocations: Services.prefs.getBoolPref("devtools.performance.ui.enable-allocations"),
> +    withOptimizations: Services.prefs.getBoolPref("devtools.performance.ui.enable-jit-optimizations"),

withJitOptimizations would be more specific.

::: browser/devtools/performance/test/browser_perf-jit-view-01.js
@@ +18,5 @@
>    let profilerData = { threads: [gThread] }
>  
> +  is(Services.prefs.getBoolPref(JIT_PREF), false, "record JIT Optimizations pref off by default");
> +  Services.prefs.setBoolPref(JIT_PREF, true);
> +  is(Services.prefs.getBoolPref(JIT_PREF), true, "toggle on record JIT Optimizations");

you really don't need this assertion lol
Attachment #8623917 - Flags: review?(vporof) → review+
Changed to withJITOptimizations
https://hg.mozilla.org/mozilla-central/rev/d479c310b3d4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.