Closed Bug 1176215 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_searchSuggestions.js | singleWordQuery - [singleWordQuery : 236] Got as many results as expected - 0 == 2

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 41.0
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files, 1 obsolete file)

comm-central part
1.49 KB, patch
aceman
: review+
Details | Diff | Splinter Review
mozilla-central part
3.33 KB, patch
adw
: review+
Details | Diff | Splinter Review
05:12:02 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_searchSuggestions.js | singleWordQuery - [singleWordQuery : 236] Got as many results as expected - 0 == 2 05:12:02 INFO - /builds/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js:check_autocomplete:236 05:12:02 INFO - self-hosted:InterpretGeneratorResume:715 05:12:02 INFO - self-hosted:next:623 05:12:02 INFO - _run_next_test@/builds/slave/test/build/tests/xpcshell/head.js:1460:9 05:12:02 INFO - do_execute_soon/<.run@/builds/slave/test/build/tests/xpcshell/head.js:653:9 05:12:02 INFO - _do_main@/builds/slave/test/build/tests/xpcshell/head.js:207:5 05:12:02 INFO - _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:513:5 05:12:02 INFO - @-e:1:1 05:12:02 INFO - exiting test 05:12:02 INFO - Unexpected exception 2147500036 05:12:02 INFO - undefined 05:12:02 INFO - exiting test 05:12:02 INFO - <<<<<<< http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/search/SearchSuggestionController.jsm#131
Must be from bug 1173751 (which added the test)
Blocks: 1173751
we added a local engine here, so we're not using defaults... why does that fail on comm-central?
There are tons of failures on each of these runs and test_searchSuggestions.js isn't even the first one, so why's this bug blaming them on it? It sure looks like there's some bigger problem here.
Because this particular test started showing up as a failure since bug 1173751 landed. Yes, the comm-central tree is not exactly green atm... that's backlog from various m-c landings.
Ok so the problem here was we had browser.search.suggest.enabled false set. That was set in bug 1059192 not to cause failure since the pref didn't exist. It's now in all.js (since bug 1117158) so we don't need to keep it.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8626925 - Flags: review?(acelists)
Attached patch mozilla-central part (obsolete) — — Splinter Review
Ensure the browser.search.suggest.enabled pref is enabled when running the test.
Attachment #8626926 - Flags: review?(adw)
really the mozilla-central part
Attachment #8626926 - Attachment is obsolete: true
Attachment #8626926 - Flags: review?(adw)
Attachment #8626927 - Flags: review?(adw)
Comment on attachment 8626925 [details] [diff] [review] comm-central part Review of attachment 8626925 [details] [diff] [review]: ----------------------------------------------------------------- So this pref is not used in TB, we just added it as tests in toolkit used it? The pref was defined when the tests were running under Firefox but not under Thunderbird? So if that is the case and we do not care what value we get from all.js in m-c (whether true or false), then the patch seems fine. Thanks for investigating it.
Attachment #8626925 - Flags: review?(acelists) → review+
Comment on attachment 8626927 [details] [diff] [review] mozilla-central part Review of attachment 8626927 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8626927 - Flags: review?(adw) → review+
c-c: https://hg.mozilla.org/comm-central/rev/205059915763
Target Milestone: --- → Thunderbird 41.0
https://hg.mozilla.org/mozilla-central/rev/b632a8d62d45
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: