1176342 - De-COM nsIXPConnect::InitClassesWithNewWrappedGlobal()

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P3)

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d2bedf403c37cf32965f43fd3fc0c52d2e078ec

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1176342, part 1 - De-COM InitClassesWithNewWrappedGlobal.

Review commit: https://reviewboard.mozilla.org/r/181470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181470/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1176342, part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal.

Review commit: https://reviewboard.mozilla.org/r/181472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181472/

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8909982 [details]
Bug 1176342, part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal.

https://reviewboard.mozilla.org/r/181472/#review186764

::: js/xpconnect/src/xpcpublic.h:203
(Diff revision 1)
>                                  JS::CompartmentOptions& aOptions,
>                                  JS::MutableHandleObject aNewGlobal);
>  
> +const uint32_t INIT_JS_STANDARD_CLASSES  = 1 << 0;
> +const uint32_t DONT_FIRE_ONNEWGLOBALHOOK = 1 << 1;
> +const uint32_t OMIT_COMPONENTS_OBJECT    = 1 << 2;

Now that we're not constrained by XPIDL, mind putting these in an enum?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8909981 [details]
Bug 1176342, part 1 - De-COM InitClassesWithNewWrappedGlobal.

https://reviewboard.mozilla.org/r/181470/#review186766

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Blake Kaplan (:mrbkap) from comment #4)
> Now that we're not constrained by XPIDL, mind putting these in an enum?

Good point. I was idly thinking about that, but then I got lazy...

Comment 7

[Andrew McCreight [:mccr8]]

Comment on attachment 8909982 [details]
Bug 1176342, part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181472/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57e73bbccac7
part 1 - De-COM InitClassesWithNewWrappedGlobal. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/fc0e284fb21b
part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal. r=mrbkap

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57e73bbccac7
https://hg.mozilla.org/mozilla-central/rev/fc0e284fb21b