Closed Bug 1176342 Opened 5 years ago Closed 3 years ago

De-COM nsIXPConnect::InitClassesWithNewWrappedGlobal()

Categories

(Core :: XPConnect, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → continuation
Depends on: 989373
Summary: De-Holder nsIXPConnect::InitClassesWithNewWrappedGlobal() → De-COM nsIXPConnect::InitClassesWithNewWrappedGlobal()
Depends on: 1365086
Assignee: continuation → nobody
Priority: -- → P3
Assignee: nobody → continuation
Blocks: deCOM
Comment on attachment 8909982 [details]
Bug 1176342, part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal.

https://reviewboard.mozilla.org/r/181472/#review186764

::: js/xpconnect/src/xpcpublic.h:203
(Diff revision 1)
>                                  JS::CompartmentOptions& aOptions,
>                                  JS::MutableHandleObject aNewGlobal);
>  
> +const uint32_t INIT_JS_STANDARD_CLASSES  = 1 << 0;
> +const uint32_t DONT_FIRE_ONNEWGLOBALHOOK = 1 << 1;
> +const uint32_t OMIT_COMPONENTS_OBJECT    = 1 << 2;

Now that we're not constrained by XPIDL, mind putting these in an enum?
Attachment #8909982 - Flags: review?(mrbkap) → review+
Comment on attachment 8909981 [details]
Bug 1176342, part 1 - De-COM InitClassesWithNewWrappedGlobal.

https://reviewboard.mozilla.org/r/181470/#review186766
Attachment #8909981 - Flags: review?(mrbkap) → review+
(In reply to Blake Kaplan (:mrbkap) from comment #4)
> Now that we're not constrained by XPIDL, mind putting these in an enum?

Good point. I was idly thinking about that, but then I got lazy...
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57e73bbccac7
part 1 - De-COM InitClassesWithNewWrappedGlobal. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/fc0e284fb21b
part 2 - De-COM the flags for InitClassesWithNewWrappedGlobal. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/57e73bbccac7
https://hg.mozilla.org/mozilla-central/rev/fc0e284fb21b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.