Closed Bug 958644 Opened 10 years ago Closed 7 years ago

Eliminate usage of nsIXPConnectJSObjectHolder for rooting JS objects

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Keywords: meta) 

In the world of exact rooting, this shouldn't be needed.  The rooting analysis doesn't understand this class, so we have to root anyways, and we end up with a lot of useless boilerplate that would be nice to remove.
Depends on: 958651
Depends on: 958778
Summary: Eliminate usage of nsIXPConnectJSObjectHolder on the stack → Eliminate usage of nsIXPConnectJSObjectHolder
Well, I guess it is okay to use on the heap, from non-main-thread-only objects.
Summary: Eliminate usage of nsIXPConnectJSObjectHolder → Eliminate usage of nsIXPConnectJSObjectHolder on the stack
Depends on: 1176341
Depends on: 1176342
It looks like jandem removed the weird storage code that used nsIXPConnectJSObjectHolder, so we should be able to rip out a lot of this now. Hooray!
Depends on: 1392554, 1390489
In addition to the blocking bugs, there are two uses of this class on the stack in txMozillaXSLTProcessor, but that is used more for dealing with pulling things out of an nsIVariant so I guess it is okay. Other than that, the only remaining uses of nsIXPConnectJSObjectHolder will be as a base class for nsIXPConnectWrappedNative and the like.
Summary: Eliminate usage of nsIXPConnectJSObjectHolder on the stack → Eliminate usage of nsIXPConnectJSObjectHolder for rooting JS objects
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.