Update SeaMonkey website for 2.35

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: philip.chee, Assigned: InvisibleSmiley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

For making SeaMonkey 2.35 public, we'll need to update the website.

Please "hg add src/releases/2.35.en.html" locally after applying the patch and before committing.
Depends on "Bug 1177794 - Release Notes 2.35 missing "
Depends on: 1177794
Depends on: SM235-RELNOTE
No longer depends on: 1177794
I copied the 2.33.1 info and made the necessary changes.  But the relnotes needs fixing.. I'll need some guidance in where/how to gather the necessary relnotes.
Attachment #8656362 - Flags: review?(jh)
Comment on attachment 8656362 [details] [diff] [review]
website changes

Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------

....and we're live!

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f2dc3f270d39

Even though I pushed, I'm leaving a r? open on Jens

::: src/releases/index.en.html
@@ +3,5 @@
>  [%- prettyversion = smversion -%]
>  [%- relnoteversion = releaserelnoteversion -%]
>  [%- mirrorred = true -%]
>  [%- uselongversion = false -%]
> +[%- releasedate = "September 9, 2015" -%]

Sep 3 ;-)
Attachment #8656362 - Flags: review+
Comment on attachment 8656362 [details] [diff] [review]
website changes

Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/sitemap.xml
@@ +17,3 @@
>        <page url="releases/seamonkey2.33/" title="Release Notes" id="seamonkey2.33"/>
>      </page>
> +    <page url="releases/2.33.1" title="2.33.1" id="2.33.1" hide="true">

This is an unclosed XML tag. please end it with |" />| like the ones below.
Comment on attachment 8656362 [details] [diff] [review]
website changes

Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/sitemap.xml
@@ +17,1 @@
>        <page url="releases/seamonkey2.33/" title="Release Notes" id="seamonkey2.33"/>

And actually, those are not the 2.35 release notes, but the 2.33 ones - the 2.33 ones should still be listed in the 2.33.1 section.
Posted patch website fix. (obsolete) — Splinter Review
Posted patch website fix (v2) (obsolete) — Splinter Review
Attachment #8656570 - Attachment is obsolete: true
Attachment #8656583 - Flags: review?(kairo)
Comment on attachment 8656583 [details] [diff] [review]
website fix (v2)

Review of attachment 8656583 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that one / removed. Sorry for misleading you earlier (that was the XML error, but there was more to do).

::: lib/sitemap.xml
@@ +15,5 @@
>    <page url="releases/" title="Download and Releases" id="releases">
>      <page url="releases/2.35" title="2.35" id="2.35" hide="false">
> +      <page url="releases/seamonkey2.35/" title="Release Notes" id="seamonkey2.35"/>
> +    </page>
> +    <page url="releases/2.33.1" title="2.33.1" id="2.33.1" hide="true"/>

Actually, now that it has children, it should not have the / in there.
Attachment #8656583 - Flags: review?(kairo) → review+
Attachment #8656583 - Attachment is obsolete: true
Attachment #8656593 - Flags: review+
Comment on attachment 8656362 [details] [diff] [review]
website changes

I actually checked the two changesets that were pushed rather than this patch. Those pushes combined look good, so r+ for that.

For future updates please note that if at the time a new release is about to be prepared, the corresponding beta section on the releases/ index page needs to be commented out as well as the link pointing to it toward the beginning of the page. In this particular case, 2.34b1 was already commented out.

On the other hand, if the version to be prepared is a beta version, the above needs to be reverted and the betarelasedate variable needs to be updated.

Also I noticed that now that we're on Mercurial we may actually hg copy existing pages when creating new release or release notes files. This was the patches will be smaller/clearer. Just a thought, by no means a requirement.
Attachment #8656362 - Flags: review?(jh) → review+
(In reply to Edmund Wong (:ewong) from comment #2)
> But the relnotes
> needs fixing.. I'll need some guidance in where/how to gather the necessary
> relnotes.

That's another bug. ;-) See you over there.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Websites → SeaMonkey
You need to log in before you can comment on or make changes to this bug.