Closed
Bug 1177048
Opened 9 years ago
Closed 9 years ago
Update SeaMonkey website for 2.35
Categories
(SeaMonkey :: Website, defect)
SeaMonkey
Website
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philip.chee, Assigned: InvisibleSmiley)
References
Details
Attachments
(2 files, 2 obsolete files)
46.36 KB,
patch
|
InvisibleSmiley
:
review+
Callek
:
review+
|
Details | Diff | Splinter Review |
1.48 KB,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
For making SeaMonkey 2.35 public, we'll need to update the website.
Please "hg add src/releases/2.35.en.html" locally after applying the patch and before committing.
Comment 2•9 years ago
|
||
I copied the 2.33.1 info and made the necessary changes. But the relnotes needs fixing.. I'll need some guidance in where/how to gather the necessary relnotes.
Attachment #8656362 -
Flags: review?(jh)
Comment 3•9 years ago
|
||
Comment on attachment 8656362 [details] [diff] [review]
website changes
Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------
....and we're live!
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f2dc3f270d39
Even though I pushed, I'm leaving a r? open on Jens
::: src/releases/index.en.html
@@ +3,5 @@
> [%- prettyversion = smversion -%]
> [%- relnoteversion = releaserelnoteversion -%]
> [%- mirrorred = true -%]
> [%- uselongversion = false -%]
> +[%- releasedate = "September 9, 2015" -%]
Sep 3 ;-)
Attachment #8656362 -
Flags: review+
Comment 4•9 years ago
|
||
Comment on attachment 8656362 [details] [diff] [review]
website changes
Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------
::: lib/sitemap.xml
@@ +17,3 @@
> <page url="releases/seamonkey2.33/" title="Release Notes" id="seamonkey2.33"/>
> </page>
> + <page url="releases/2.33.1" title="2.33.1" id="2.33.1" hide="true">
This is an unclosed XML tag. please end it with |" />| like the ones below.
Comment 5•9 years ago
|
||
Comment on attachment 8656362 [details] [diff] [review]
website changes
Review of attachment 8656362 [details] [diff] [review]:
-----------------------------------------------------------------
::: lib/sitemap.xml
@@ +17,1 @@
> <page url="releases/seamonkey2.33/" title="Release Notes" id="seamonkey2.33"/>
And actually, those are not the 2.35 release notes, but the 2.33 ones - the 2.33 ones should still be listed in the 2.33.1 section.
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Attachment #8656570 -
Attachment is obsolete: true
Attachment #8656583 -
Flags: review?(kairo)
Comment 8•9 years ago
|
||
Comment on attachment 8656583 [details] [diff] [review]
website fix (v2)
Review of attachment 8656583 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with that one / removed. Sorry for misleading you earlier (that was the XML error, but there was more to do).
::: lib/sitemap.xml
@@ +15,5 @@
> <page url="releases/" title="Download and Releases" id="releases">
> <page url="releases/2.35" title="2.35" id="2.35" hide="false">
> + <page url="releases/seamonkey2.35/" title="Release Notes" id="seamonkey2.35"/>
> + </page>
> + <page url="releases/2.33.1" title="2.33.1" id="2.33.1" hide="true"/>
Actually, now that it has children, it should not have the / in there.
Attachment #8656583 -
Flags: review?(kairo) → review+
Comment 9•9 years ago
|
||
Attachment #8656583 -
Attachment is obsolete: true
Attachment #8656593 -
Flags: review+
Comment 10•9 years ago
|
||
Comment on attachment 8656593 [details] [diff] [review]
website fix (v3)
Pushed to Website:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/5fbb6f40984e
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8656362 [details] [diff] [review]
website changes
I actually checked the two changesets that were pushed rather than this patch. Those pushes combined look good, so r+ for that.
For future updates please note that if at the time a new release is about to be prepared, the corresponding beta section on the releases/ index page needs to be commented out as well as the link pointing to it toward the beginning of the page. In this particular case, 2.34b1 was already commented out.
On the other hand, if the version to be prepared is a beta version, the above needs to be reverted and the betarelasedate variable needs to be updated.
Also I noticed that now that we're on Mercurial we may actually hg copy existing pages when creating new release or release notes files. This was the patches will be smaller/clearer. Just a thought, by no means a requirement.
Attachment #8656362 -
Flags: review?(jh) → review+
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to Edmund Wong (:ewong) from comment #2)
> But the relnotes
> needs fixing.. I'll need some guidance in where/how to gather the necessary
> relnotes.
That's another bug. ;-) See you over there.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Websites → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•