1178274 - Properly check for APZ enabled when doing decode-only-on-draw

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The AsyncPanZoomEnableDoNotUseDirectly() call in ImageFactory.cpp means that if the APZ pref is enabled but e10s is disabled, we still enable decode-only-on-draw. We shouldn't do this. This appears to be why the layout/reftests/image/image-orientation-border-image.html?90&flip reftest fails on Mac and Windows when the APZ pref is enabled. (It doesn't fix the problem on Linux R-e10s though; I suspect that the reftest harness just doesn't wait for the image decoding before taking its snapshot, causing the test failure - we can fix that in bug 1177323).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Patch

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=67ec1b076ad0

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8627180 [details] [diff] [review]
Part 2 - Patch

Oh, this appears to be called on non-main thread in some xpcshell tests and crashes.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Ensure xpcshell tests initialize BrowserTabsRemoteAutostart on the main thread

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d72455a884e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e51ef562f1c5

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d72455a884e
https://hg.mozilla.org/mozilla-central/rev/e51ef562f1c5