1724089 - Remove the browser.tabs.remote.autostart pref, it does not do anything in xpcshell tests

Reporter

Description

•

3 years ago

The browser.tabs.remote.autostart pref can be set to false to disable e10s.
While it defaults to false, it is true in practice:

The only active user of this pref are some xpcshell tests. The pref is always set too late, so this doesn't ever work actually: When BrowserTabsRemoteAutostart() is called, the pref is read once and the result is cached. In xpcshell tests, prefs are set at runtime, either in head.js (that reads from user.js) or in the extension tests' head.js. But xpcshell tests already initialize BrowserTabsRemoteAutostart() before the prefs are read. Currently the following callers are triggered before the prefs are read:

Added in bug 1582512 (2019): XPCJSRuntime::Initialize calls XRE_IsE10sParentProcess() which in turn calls BrowserTabsRemoteAutostart()
Added in bug 1178274 (2015): XRE_XPCShellMain calls BrowserTabsRemoteAutostart() directly.

I also checked the effectiveness of the pref in non-xpcshell tests, by initializing a directory with a user.js containing user_pref("browser.tabs.remote.autostart", false); and running Firefox with it (from Treeherder, because the pref is disabled in official Firefox builds), but according to about:support e10s is not disabled. I also tried a local build with the same effect: ./mach run --temp-profile --setpref=browser.tabs.remote.autostart=false (I didn't check, but I guess that prefs might be read after JS initialization?)

Since the pref cannot be disabled via xpcshell tests, I suggest to remove it altogether. It would still be possible to disable e10s, via MOZ_FORCE_DISABLE_E10S.

Rob Wu [:robwu]

Reporter

Updated

•

3 years ago

Updated

•

3 years ago

Severity: -- → S4

Julian Seward [:jseward]

Comment 1

•

2 years ago

Setting browser.tabs.remote.autostart to false and then loading https://lab.allotropia.de/wasm crashes the browser instantly (m-c of 14 Oct 2022, on Linux). This is disconcerting to say the least and I spent a couple of hours chasing it, thinking it was a SM/wasm bug. So +1 for removing it entirely.

Gregory Pappas [:gregp]

Assignee

Comment 2

•

10 months ago

Attached file Bug 1724089 - Remove browser.tabs.remote.autostart pref r?mossop!,robwu! (obsolete) — Details

Phabricator Automation

Updated

•

10 months ago

Assignee: nobody → gp3033

Status: NEW → ASSIGNED

Phabricator Automation

Updated

•

9 months ago

Attachment #9340845 - Attachment is obsolete: true

Gregory Pappas [:gregp]

Assignee

Comment 3

•

8 months ago

Attached file Bug 1724089 - Stop using browser.tabs.remote.autostart pref in accessible/tests/browser/ r?morgan — Details

Gregory Pappas [:gregp]

Assignee

Updated

•

8 months ago

Keywords: leave-open

Gregory Pappas [:gregp]

Assignee

Comment 4

•

8 months ago

Attached file Bug 1724089 - Remove browser.tabs.remote.autostart pref (obsolete) — Details

Pulsebot

Comment 5

•

8 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddc3d1e9268d
Stop using browser.tabs.remote.autostart pref in accessible/tests/browser/ r=morgan

Cristian Tuns

Comment 6

•

8 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ddc3d1e9268d

Phabricator Automation

Updated

•

6 months ago

Attachment #9348955 - Attachment description: WIP: Bug 1724089 - Remove browser.tabs.remote.autostart pref → Bug 1724089 - Remove browser.tabs.remote.autostart pref

Gregory Pappas [:gregp]

Assignee

Updated

•

6 months ago

Blocks: old-prefs

Keywords: leave-open

Phabricator Automation

Updated

•

6 months ago

Attachment #9348955 - Attachment is obsolete: true

Gregory Pappas [:gregp]

Assignee

Comment 7

•

6 months ago

Attached file Bug 1724089 - Remove browser.tabs.remote.autostart pref — Details

Phabricator Automation

Updated

•

6 months ago

Attachment #9360838 - Attachment description: WIP: Bug 1724089 - Remove browser.tabs.remote.autostart pref → Bug 1724089 - Remove browser.tabs.remote.autostart pref

Rob Wu [:robwu]

Reporter

Updated

•

5 months ago

Blocks: 1863223

Pulsebot

Comment 8

•

5 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/36cd4787833a
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 9

•

5 months ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43009 for changes under testing/web-platform/tests

Sandor Molnar[:smolnar]

Comment 10

•

5 months ago

•

Edited

Backed out for causing xpc failures on docshell/test/unit/test_subframe_stop_after_parent_error.js & android WD failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/75638fb876b74a0aebdb45d1315fb43bcc0e4098

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | docshell/test/unit/test_subframe_stop_after_parent_error.js | xpcshell return code: -11

Failure log -> TEST-UNEXPECTED-FAIL | widget/headless/tests/test_headless.js | xpcshell return code: -11

Failure log Android WD ->

L.E. also these Failure log ->TEST-UNEXPECTED-TIMEOUT | dom/base/test/unit/test_blockParsing.js | Test timed out

Failure log valgrind ->TEST-UNEXPECTED-FAIL | valgrind-test | Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s) at __libc_sendmsg / sendmsg / corrected_sendmsg / IPC::Channel::ChannelImpl::ProcessOutgoingMessages

Flags: needinfo?(gregp)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 11

•

5 months ago

Upstream PR was closed without merging

Jamie Nicol [:jnicol]

Updated

•

5 months ago

Blocks: 1863557

Mathew Hodson

Updated

•

4 months ago

Type: defect → task

Pulsebot

Comment 12

•

4 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/88de278b4ca9
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish

Serban Stanca [:SerbanS]

Comment 13

•

4 months ago

Backed out for causing xpcshell failures.

Backout link
Push with failures
Failure Log 1
Failure Log 2
Failure line 1: TEST-UNEXPECTED-TIMEOUT | dom/base/test/unit/test_blockParsing.js | Test timed out
Failure line 2: TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_cookies_thirdparty.js | Test timed out

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 14

•

4 months ago

Upstream PR was closed without merging

Pulsebot

Comment 15

•

4 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/399d9781e72b
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish

Narcis Beleuzu [:NarcisB]

Comment 16

•

4 months ago

•

Edited

Backed out for causing xpcshell failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/4207f08a02489bc8af35f713ac39805740ac0d1c
Log link 1: https://treeherder.mozilla.org/logviewer?job_id=441888919&repo=autoland&lineNumber=4242
Log link 2: https://treeherder.mozilla.org/logviewer?job_id=441888930&repo=autoland&lineNumber=4821
Log link 3: https://treeherder.mozilla.org/logviewer?job_id=441888831&repo=autoland&lineNumber=5335

There was also a perma valgrind bustage: https://treeherder.mozilla.org/logviewer?job_id=441902997&repo=autoland&lineNumber=90613

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 17

•

4 months ago

Upstream PR was closed without merging

Gregory Pappas [:gregp]

Assignee

Comment 18

•

3 months ago

For anyone curious about the current status:

I've discovered that some xpcshell tests are running with e10s disabled and others are not. It's not clear yet how this is happening.

My current understanding is that under normal circumstances, xpcshell will have e10s disabled because the pref is false in all.js
https://searchfox.org/mozilla-central/rev/6f90f50b7a32cc062ab755e0653b3d3f512fe3bd/modules/libpref/init/all.js#2026

And of course, xpcshell isn't firefox so there's nothing overriding that. There are about 20 tests that I think accidentally depend on this behavior and need to be updated. What I'm still working out is why some xpcshell tests are in fact running with e10s enabled (determined by printf debugging in nsAppRunner).

Rob Wu [:robwu]

Reporter

Comment 19

•

3 months ago

(In reply to Gregory Pappas [:gregp] from comment #18)

I've discovered that some xpcshell tests are running with e10s disabled and others are not. It's not clear yet how this is happening.

My current understanding is that under normal circumstances, xpcshell will have e10s disabled because the pref is false in all.js
https://searchfox.org/mozilla-central/rev/6f90f50b7a32cc062ab755e0653b3d3f512fe3bd/modules/libpref/init/all.js#2026

And of course, xpcshell isn't firefox so there's nothing overriding that.

There is, wherever firefox-appdir = browser is used: https://searchfox.org/mozilla-central/search?q=firefox-appdir&path=&case=false&regexp=false

There is even a comment calling out this behavior at https://searchfox.org/mozilla-central/rev/6f90f50b7a32cc062ab755e0653b3d3f512fe3bd/dom/workers/test/xpcshell/xpcshell.toml#22-25
(I think that prefs = ["browser.tabs.remote.autostart=true"] would also have worked there instead.)

Gregory Pappas [:gregp]

Assignee

Comment 20

•

3 months ago

Thanks! I think I have an idea for how to proceed now then.

Flags: needinfo?(gregp)

Pulsebot

Comment 21

•

3 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/be072303feaf
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish,necko-reviewers,jmaher,valentin

Noemi Erli[:noemi_erli]

Comment 22

•

3 months ago

Backed out changeset be072303feaf (Bug 1724089) for causing xpc failures in test_headless.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=be072303feafdac9f5574eb97613a65b9784d9b7&selectedTaskRun=XwqG1MBQRVa4x9D6wmN36g.0

Log: https://treeherder.mozilla.org/logviewer?job_id=443792354&repo=autoland&lineNumber=4238
https://treeherder.mozilla.org/logviewer?job_id=443793603&repo=autoland&lineNumber=90829

Backout: https://hg.mozilla.org/integration/autoland/rev/af7b5d7955528c43f5fe4957705002f2d3ec0718

Flags: needinfo?(gregp)

Pulsebot

Comment 23

•

3 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/da092d881d44
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish,necko-reviewers,jmaher,valentin

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 24

•

3 months ago

Upstream PR was closed without merging

Iulian Moraru

Comment 25

•

3 months ago

Backed out for causing valgrind build bustages.

[task 2024-01-18T19:28:58.021Z] 19:28:58     INFO -  --3957-- failed to stat64/stat this file
[task 2024-01-18T19:28:58.041Z] 19:28:58     INFO -  ==4124== Warning: set address range perms: large range [0x2aa7c6ab4000, 0x2aa8466b4000) (noaccess)
[task 2024-01-18T19:28:58.045Z] 19:28:58     INFO -  ==3957== Thread 3 IPC I/O Parent:
[task 2024-01-18T19:28:58.045Z] 19:28:58     INFO -  TEST-UNEXPECTED-FAIL | valgrind-test | Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s) at __libc_sendmsg / sendmsg / corrected_sendmsg / IPC::Channel::ChannelImpl::ProcessOutgoingMessages
[task 2024-01-18T19:28:58.045Z] 19:28:58     INFO -  ==3957== Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s)
[task 2024-01-18T19:28:58.045Z] 19:28:58     INFO -  ==3957==    at 0x4C8590D: __libc_sendmsg (sendmsg.c:28)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0x4C8590D: sendmsg+77 (sendmsg.c:25)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB511AF7: corrected_sendmsg (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:131)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB511AF7: IPC::Channel::ChannelImpl::ProcessOutgoingMessages()+1191 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:665)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB513549: Send (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:799)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB513549: IPC::Channel::Send(mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >)+121 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:1193)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB559BC1: mozilla::ipc::NodeChannel::SendMessage(mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >)+97 (checkouts/gecko/ipc/glue/NodeChannel.cpp:197)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB55B556: SendEventMessage (checkouts/gecko/ipc/glue/NodeChannel.cpp:133)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB55B556: mozilla::ipc::NodeController::ForwardEvent(mojo::core::ports::NodeName const&, mozilla::UniquePtr<mojo::core::ports::Event, mozilla::DefaultDelete<mojo::core::ports::Event> >)+342 (checkouts/gecko/ipc/glue/NodeController.cpp:382)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB51CC34: mojo::core::ports::Node::ForwardUserMessagesFromProxy(mojo::core::ports::PortRef const&)+356 (checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:1457)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB51CFEA: mojo::core::ports::Node::BeginProxying(mojo::core::ports::PortRef const&)+362 (checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:1397)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB51A324: OnPortAccepted (checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:599)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB51A324: mojo::core::ports::Node::AcceptEvent(mozilla::UniquePtr<mojo::core::ports::Event, mozilla::DefaultDelete<mojo::core::ports::Event> >)+244 (checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:415)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB55C520: mozilla::ipc::NodeController::OnEventMessage(mojo::core::ports::NodeName const&, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >)+832 (checkouts/gecko/ipc/glue/NodeController.cpp:546)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB559E82: mozilla::ipc::NodeChannel::OnMessageReceived(mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >)+226 (checkouts/gecko/ipc/glue/NodeChannel.cpp:266)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB51297D: IPC::Channel::ChannelImpl::ProcessIncomingMessages()+2541 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:530)
[task 2024-01-18T19:28:58.048Z] 19:28:58     INFO -  ==3957==    by 0xB5130DE: IPC::Channel::ChannelImpl::OnFileCanReadWithoutBlocking(int)+46 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:812)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB509835: base::MessagePumpLibevent::OnLibeventNotification(int, short, void*)+213 (checkouts/gecko/ipc/chromium/src/base/message_pump_libevent.cc:261)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB52664B: event_persist_closure (checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:1623)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB52664B: event_process_active_single_queue+1371 (checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:1682)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB524370: event_process_active (checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:0)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB524370: event_base_loop+1600 (checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:2006)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB509B7E: base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)+414 (checkouts/gecko/ipc/chromium/src/base/message_pump_libevent.cc:0)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB5080C4: RunInternal (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:370)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB5080C4: RunHandler (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:363)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB5080C4: MessageLoop::Run()+84 (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:345)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB51060D: base::Thread::ThreadMain()+477 (checkouts/gecko/ipc/chromium/src/base/thread.cc:186)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB50DBB9: ThreadFunc(void*)+9 (checkouts/gecko/ipc/chromium/src/base/platform_thread_posix.cc:41)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0x12FED3: set_alt_signal_stack_and_start(PthreadCreateParams*)+211 (checkouts/gecko/mozglue/interposers/pthread_create_interposer.cpp:81)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0x4C03FD3: start_thread+707 (pthread_create.c:442)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0x4C8381F: clone+63 (clone.S:100)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==  Address 0x24aafb0b is 3,259 bytes inside a block of size 4,096 alloc'd
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    at 0x48407B4: malloc+116 (vg_replace_malloc.c:393)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0x12F65D: moz_xmalloc+13 (checkouts/gecko/memory/mozalloc/mozalloc.cpp:52)
[task 2024-01-18T19:28:58.049Z] 19:28:58     INFO -  ==3957==    by 0xB50F96F: pod_malloc<char> (dist/include/mozilla/mozalloc.h:161)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB50F96F: AllocateSegment (dist/include/mozilla/BufferList.h:406)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB50F96F: mozilla::BufferList<InfallibleAllocPolicy>::AllocateBytes(unsigned long, unsigned long*)+95 (dist/include/mozilla/BufferList.h:476)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB50AE00: WriteBytes (dist/include/mozilla/BufferList.h:443)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB50AE00: Pickle::WriteBytes(void const*, unsigned int)+160 (checkouts/gecko/ipc/chromium/src/base/pickle.cc:470)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB50A965: Pickle::WriteUInt32(unsigned int)+37 (checkouts/gecko/ipc/chromium/src/base/pickle.cc:415)
[task 2024-01-18T19:28:58.050Z] 19:28:58     INFO -  ==3957==    by 0xB0650F2: WriteUInt32 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:74)
[task 2024-01-18T19:28:58.051Z] 19:28:58     INFO -  ==3957==    by 0xB0650F2: void IPC::WriteSequenceParam<nsTString<char> const&>(IPC::MessageWriter*, std::remove_reference<nsTString<char> const&>::type*, unsigned long)+66 (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:579)
[task 2024-01-18T19:28:58.051Z] 19:28:58     INFO -  ==3957==    by 0xD7ABACE: Write (dist/include/ipc/IPCMessageUtilsSpecializations.h:165)
[task 2024-01-18T19:28:58.051Z] 19:28:58     INFO -  ==3957==    by 0xD7ABACE: WriteParam<const nsTArray<nsTString<char> > &> (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:441)
[task 2024-01-18T19:28:58.051Z] 19:28:58     INFO -  ==3957==    by 0xD7ABACE: IPC::ParamTraits<mozilla::dom::XPCOMInitData>::Write(IPC::MessageWriter*, mozilla::dom::XPCOMInitData const&)+190 (ipc/ipdl/PContent.cpp:4537)
[task 2024-01-18T19:28:58.051Z] 19:28:58     INFO -  ==3957==    by 0xD7E6C3A: WriteParam<const mozilla::dom::XPCOMInitData &> (checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h:441)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD7E6C3A: mozilla::dom::PContentParent::SendSetXPCOMProcessAttributes(mozilla::dom::XPCOMInitData const&, mozilla::dom::ipc::StructuredCloneData const&, mozilla::widget::FullLookAndFeel const&, mozilla::dom::SystemFontList const&, mozilla::Maybe<mozilla::UniquePtr<int, mozilla::detail::FileHandleDeleter> >&&, unsigned long const&, nsTArray<mozilla::UniquePtr<int, mozilla::detail::FileHandleDeleter> >&&, bool const&)+106 (ipc/ipdl/PContentParent.cpp:3413)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD71F17F: mozilla::dom::ContentParent::InitInternal(mozilla::hal::ProcessPriority)+2687 (checkouts/gecko/dom/ipc/ContentParent.cpp:3162)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD71A6EA: mozilla::dom::ContentParent::LaunchSubprocessResolve(bool, mozilla::hal::ProcessPriority)+1002 (checkouts/gecko/dom/ipc/ContentParent.cpp:2779)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD71A191: mozilla::dom::ContentParent::WaitForLaunchSync(mozilla::hal::ProcessPriority)+113 (checkouts/gecko/dom/ipc/ContentParent.cpp:1192)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD71B00D: GetNewOrUsedBrowserProcess (checkouts/gecko/dom/ipc/ContentParent.cpp:1134)
[task 2024-01-18T19:28:58.052Z] 19:28:58     INFO -  ==3957==    by 0xD71B00D: mozilla::dom::ContentParent::CreateBrowser(mozilla::dom::TabContext const&, mozilla::dom::Element*, nsTSubstring<char> const&, mozilla::dom::BrowsingContext*, mozilla::dom::ContentParent*)+685 (checkouts/gecko/dom/ipc/ContentParent.cpp:1479)
[task 2024-01-18T19:28:58.053Z] 19:28:58     INFO -  ==3957==    by 0xBE374D7: nsFrameLoader::TryRemoteBrowserInternal()+1543 (checkouts/gecko/dom/base/nsFrameLoader.cpp:2742)
[task 2024-01-18T19:28:58.053Z] 19:28:58     INFO -  ==3957==    by 0xBE3156A: TryRemoteBrowser (checkouts/gecko/dom/base/nsFrameLoader.cpp:2808)
[task 2024-01-18T19:28:58.053Z] 19:28:58     INFO -  ==3957==    by 0xBE3156A: EnsureRemoteBrowser (checkouts/gecko/dom/base/nsFrameLoader.cpp:2539)
[task 2024-01-18T19:28:58.053Z] 19:28:58     INFO -  ==3957==    by 0xBE3156A: nsFrameLoader::ShowRemoteFrame(mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, nsSubDocumentFrame*)+170 (checkouts/gecko/dom/base/nsFrameLoader.cpp:1093)
[task 2024-01-18T19:28:58.053Z] 19:28:58     INFO -  ==3957==    by 0xBE322E6: nsFrameLoader::Show(nsSubDocumentFrame*)+182 (checkouts/gecko/dom/base/nsFrameLoader.cpp:979)
[task 2024-01-18T19:28:58.054Z] 19:28:58     INFO -  ==3957==    by 0xDFD49A5: nsSubDocumentFrame::ShowViewer()+245 (checkouts/gecko/layout/generic/nsSubDocumentFrame.cpp:202)
[task 2024-01-18T19:28:58.054Z] 19:28:58     INFO -  ==3957==    by 0xDFFEA2C: AsyncFrameInit::Run()+140 (checkouts/gecko/layout/generic/nsSubDocumentFrame.cpp:110)
[task 2024-01-18T19:28:58.054Z] 19:28:58     INFO -  ==3957==    by 0xBC2ED15: nsContentUtils::RemoveScriptBlocker()+293 (checkouts/gecko/dom/base/nsContentUtils.cpp:6130)
[task 2024-01-18T19:28:58.054Z] 19:28:58     INFO -  ==3957==    by 0xDE573FD: ~nsAutoScriptBlocker (checkouts/gecko/dom/base/nsContentUtils.h:3688)
[task 2024-01-18T19:28:58.054Z] 19:28:58     INFO -  ==3957==    by 0xDE573FD: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush)+2045 (checkouts/gecko/layout/base/PresShell.cpp:4334)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBD435AD: FlushPendingNotifications (dist/include/mozilla/PresShell.h:1474)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBD435AD: mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush)+445 (checkouts/gecko/dom/base/Document.cpp:10991)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBE36FF0: nsFrameLoader::TryRemoteBrowserInternal()+288 (checkouts/gecko/dom/base/nsFrameLoader.cpp:2573)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBE31209: TryRemoteBrowser (checkouts/gecko/dom/base/nsFrameLoader.cpp:2808)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBE31209: EnsureRemoteBrowser (checkouts/gecko/dom/base/nsFrameLoader.cpp:2539)
[task 2024-01-18T19:28:58.055Z] 19:28:58     INFO -  ==3957==    by 0xBE31209: nsFrameLoader::ReallyStartLoadingInternal()+1353 (checkouts/gecko/dom/base/nsFrameLoader.cpp:735)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBE30C9E: nsFrameLoader::ReallyStartLoading()+14 (checkouts/gecko/dom/base/nsFrameLoader.cpp:650)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBD3EB87: mozilla::dom::Document::MaybeInitializeFinalizeFrameLoaders()+167 (checkouts/gecko/dom/base/Document.cpp:9508)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: operator()<> (dist/include/nsThreadUtils.h:1164)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: __invoke_impl<void, (lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9)> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:60)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: __invoke<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9)> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:95)
[task 2024-01-18T19:28:58.056Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: __apply_impl<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), std::tuple<> &> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1678)
[task 2024-01-18T19:28:58.057Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: apply<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), std::tuple<> &> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1687)
[task 2024-01-18T19:28:58.057Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> (dist/include/nsThreadUtils.h:1162)
[task 2024-01-18T19:28:58.057Z] 19:28:58     INFO -  ==3957==    by 0xBD81CA6: mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run()+38 (dist/include/nsThreadUtils.h:1213)
[task 2024-01-18T19:28:58.057Z] 19:28:58     INFO -  ==3957==    by 0xBC2ED15: nsContentUtils::RemoveScriptBlocker()+293 (checkouts/gecko/dom/base/nsContentUtils.cpp:6130)
[task 2024-01-18T19:28:58.057Z] 19:28:58     INFO -  ==3957==    by 0xBD3A2BB: mozilla::dom::Document::EndUpdate()+267 (checkouts/gecko/dom/base/Document.cpp:8028)
[task 2024-01-18T19:28:58.058Z] 19:28:58     INFO -  ==3957==    by 0xBE4EDA9: ~mozAutoDocUpdate (checkouts/gecko/dom/base/mozAutoDocUpdate.h:34)
[task 2024-01-18T19:28:58.058Z] 19:28:58     INFO -  ==3957==    by 0xBE4EDA9: nsINode::ReplaceOrInsertBefore(bool, nsINode*, nsINode*, mozilla::ErrorResult&)+3593 (checkouts/gecko/dom/base/nsINode.cpp:2862)
[task 2024-01-18T19:28:58.058Z] 19:28:58     INFO -  ==3957==    by 0xC094D76: InsertBefore (checkouts/gecko/dom/base/nsINode.h:2154)
[task 2024-01-18T19:28:58.058Z] 19:28:58     INFO -  ==3957==    by 0xC094D76: AppendChild (checkouts/gecko/dom/base/nsINode.h:2161)
[task 2024-01-18T19:28:58.058Z] 19:28:58     INFO -  ==3957==    by 0xC094D76: mozilla::dom::Node_Binding::appendChild(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&)+406 (NodeBinding.cpp:959)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xC8366CC: bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)+348 (checkouts/gecko/dom/bindings/BindingUtils.cpp:3258)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xF054352: CallJSNative (checkouts/gecko/js/src/vm/Interpreter.cpp:479)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xF054352: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)+530 (checkouts/gecko/js/src/vm/Interpreter.cpp:573)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xF05F864: InternalCall (checkouts/gecko/js/src/vm/Interpreter.cpp:640)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xF05F864: CallFromStack (checkouts/gecko/js/src/vm/Interpreter.cpp:645)
[task 2024-01-18T19:28:58.059Z] 19:28:58     INFO -  ==3957==    by 0xF05F864: js::Interpret(JSContext*, js::RunState&)+36692 (checkouts/gecko/js/src/vm/Interpreter.cpp:3060)
[task 2024-01-18T19:28:58.060Z] 19:28:58     INFO -  ==3957==    by 0xF053FA6: MaybeEnterInterpreterTrampoline (checkouts/gecko/js/src/vm/Interpreter.cpp:393)
[task 2024-01-18T19:28:58.060Z] 19:28:58     INFO -  ==3957==    by 0xF053FA6: js::RunScript(JSContext*, js::RunState&)+838 (checkouts/gecko/js/src/vm/Interpreter.cpp:451)
[task 2024-01-18T19:28:58.060Z] 19:28:58     INFO -  ==3957==    by 0xF054609: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)+1225 (checkouts/gecko/js/src/vm/Interpreter.cpp:605)
[task 2024-01-18T19:28:58.060Z] 19:28:58     INFO -  ==3957==    by 0xF054B0D: InternalCall (checkouts/gecko/js/src/vm/Interpreter.cpp:640)
[task 2024-01-18T19:28:58.060Z] 19:28:58     INFO -  ==3957==    by 0xF054B0D: js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason)+173 (checkouts/gecko/js/src/vm/Interpreter.cpp:672)
[task 2024-01-18T19:28:58.061Z] 19:28:58     INFO -  ==3957==    by 0xF1F53FE: js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)+238 (checkouts/gecko/js/src/vm/SelfHosting.cpp:1520)
[task 2024-01-18T19:28:58.061Z] 19:28:58     INFO -  ==3957==
[task 2024-01-18T19:28:58.061Z] 19:28:58     INFO -  {

Flags: needinfo?(gregp)

Iulian Moraru

Updated

•

3 months ago

Flags: needinfo?(gregp)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 26

•

3 months ago

Upstream PR was closed without merging

Rob Wu [:robwu]

Reporter

Comment 27

•

3 months ago

Greg, given the number of unexpected failures, could you wait until Monday (after the version bump) before retrying to land the patch again? We are currently at soft freeze, where we should try to minimize the risk of introducing regressions.

Pulsebot

Comment 28

•

3 months ago

Pushed by gp3033@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/4de25e9a9500
Remove browser.tabs.remote.autostart pref r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jgraham,extension-reviewers,mossop,sparky,robwu,owlish,necko-reviewers,jmaher,valentin

Pulsebot

Comment 29

•

3 months ago

Backout by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/1cbc58c53a33
Backed out changeset da092d881d44 for causing valgrind build bustages.

Narcis Beleuzu [:NarcisB]

Comment 30

•

3 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4de25e9a9500

Status: ASSIGNED → RESOLVED

Closed: 3 months ago

status-firefox124: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 124 Branch

Gregory Pappas [:gregp]

Assignee

Updated

•

3 months ago

Flags: needinfo?(gregp)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 31

•

3 months ago

Upstream PR was closed without merging

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 32

•

3 months ago

Upstream PR merged by lutien

Pulsebot

Comment 33

•

3 months ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73aaa07bb38e
[wpt PR 43009] - [Gecko Bug 1724089] Remove browser.tabs.remote.autostart pref, a=testonly

Sandor Molnar[:smolnar]

Comment 34

•

3 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/73aaa07bb38e

Ryan VanderMeulen [:RyanVM]

Updated

•

2 months ago

Blocks: 1843605

Rob Wu [:robwu]

Reporter

Updated

•

1 month ago

Regressions: 1884814

Nika Layzell [:nika] (ni? for response)

Updated

•

22 days ago

Regressions: 1887716

Bug 1724089 - Remove browser.tabs.remote.autostart pref r?mossop!,robwu! 10 months ago Gregory Pappas [:gregp] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1724089 - Stop using browser.tabs.remote.autostart pref in accessible/tests/browser/ r?morgan 8 months ago Gregory Pappas [:gregp] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1724089 - Remove browser.tabs.remote.autostart pref 8 months ago Gregory Pappas [:gregp] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1724089 - Remove browser.tabs.remote.autostart pref 6 months ago Gregory Pappas [:gregp] 48 bytes, text/x-phabricator-request		Details \| Review