Open Bug 1724089 Opened 1 year ago Updated 1 year ago

Remove the browser.tabs.remote.autostart pref, it does not do anything in xpcshell tests

Categories

(Toolkit :: Startup and Profile System, defect)

defect

Tracking

()

People

(Reporter: robwu, Unassigned)

References

Details

The browser.tabs.remote.autostart pref can be set to false to disable e10s.
While it defaults to false, it is true in practice:

The only active user of this pref are some xpcshell tests. The pref is always set too late, so this doesn't ever work actually: When BrowserTabsRemoteAutostart() is called, the pref is read once and the result is cached. In xpcshell tests, prefs are set at runtime, either in head.js (that reads from user.js) or in the extension tests' head.js. But xpcshell tests already initialize BrowserTabsRemoteAutostart() before the prefs are read. Currently the following callers are triggered before the prefs are read:

I also checked the effectiveness of the pref in non-xpcshell tests, by initializing a directory with a user.js containing user_pref("browser.tabs.remote.autostart", false); and running Firefox with it (from Treeherder, because the pref is disabled in official Firefox builds), but according to about:support e10s is not disabled. I also tried a local build with the same effect: ./mach run --temp-profile --setpref=browser.tabs.remote.autostart=false (I didn't check, but I guess that prefs might be read after JS initialization?)

Since the pref cannot be disabled via xpcshell tests, I suggest to remove it altogether. It would still be possible to disable e10s, via MOZ_FORCE_DISABLE_E10S.

See Also: → 1724094
Severity: -- → S4
You need to log in before you can comment on or make changes to this bug.