1178856 - Expose add-ons API using `navigator.hasFeature()`

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Doug Sherk (:drs) (inactive)]

Marketplace would like to be able to detect whether or not a user's device supports add-ons. If they're not supported, we won't let the user install add-ons.

Comment 1

[Ken Chang[:kenkai]]

Hi Hsinyi, can you find someone in your team to work on this bug? Thanks.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Talking with Edgar, he is willing to take. Thank you :)

Comment 3

[Edgar Chen [:edgar]]

There are three namespaces (hardware, api, manifest) in feature detection API [1]. But add-on seems not belong to any of them. So I propose to have a new namespace called `addon` and only available on b2g. Then Marketplace can use `navigator.hasFeature('addon')` to detect whether the device supports add-ons. And also we can extend it to detect more features where needed, e.g. `navigator.hasFeature('addon.foo.bar')`.

How does this sound?

Thank you.

[1] https://wiki.mozilla.org/WebAPI/Navigator.hasFeature

Comment 4

[[:fabrice] Fabrice Desré]

I would use 'extensions' instead of 'addons' to match the code maybe, but no big deal. Naming is hard :)

Comment 5

[Wil Clouser [:clouserw]]

Extensions are a type of add-on (others being themes, dictionaries, language packs, search engines).  If this is specifically extensions, let's definitely use that name.

Edgar:  what's your timeline for this?  The marketplace needs this to land before it can make the 2.5 package blocking other bugs (like bug 1155585).  Thanks.

Comment 6

[[:fabrice] Fabrice Desré]

I would even go with "web-extensions" since it's the "official" name for the new extensions.

Comment 7

[Edgar Chen [:edgar]]

(In reply to [:fabrice] Fabrice Desré from comment #6)
> I would even go with "web-extensions" since it's the "official" name for the
> new extensions.

Sounds good, I will go with "web-extensions", thank you.

(In reply to Wil Clouser [:clouserw] from comment #5)
> Extensions are a type of add-on (others being themes, dictionaries, language
> packs, search engines).  If this is specifically extensions, let's
> definitely use that name.
> 
> Edgar:  what's your timeline for this?  The marketplace needs this to land
> before it can make the 2.5 package blocking other bugs (like bug 1155585). 
> Thanks.

I am going to start working on this and plan to land it by end of this sprint. Thank you.

Comment 8

[David Durst [:ddurst]]

It's my understanding that we don't need this. Please hold off until tomorrow and I can confirm/deny.

Comment 9

[David Durst [:ddurst]]

Countermanding #c8, please proceed.

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4683e58aa29d

Comment 11

[Edgar Chen [:edgar]]

Attachment: MozReview Request: Bug 1178856 - Create an API for detecting web-extensions support on b2g. r?fabrice

Bug 1178856 - Create an API for detecting web-extensions support on b2g. r?fabrice

Comment 12

[[:fabrice] Fabrice Desré]

Comment on attachment 8655271 [details]
MozReview Request: Bug 1178856 - Create an API for detecting web-extensions support on b2g. r?fabrice

https://reviewboard.mozilla.org/r/17905/#review16083

::: dom/base/Navigator.cpp:1602
(Diff revision 1)
> +#ifdef MOZ_B2G

I'm not convinced this needs to be guarded by MOZ_B2G since we also have support on firefox desktop.

Comment 13

[[:fabrice] Fabrice Desré]

Comment on attachment 8655271 [details]
MozReview Request: Bug 1178856 - Create an API for detecting web-extensions support on b2g. r?fabrice

https://reviewboard.mozilla.org/r/17905/#review16125

Comment 14

[Edgar Chen [:edgar]]

Thank you, Fabrice.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/c2199af05488

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2199af05488