Closed Bug 1178961 Opened 5 years ago Closed 5 years ago

Crash on retrieving Gecko profile

Categories

(Core :: Gecko Profiler, defect)

41 Branch
ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1167230 +++

STR:
1. Install Gecko Profiler add-on.
2. Connect to Android device via USB.
3. Press "Analyze" in the add-on to retrieve the profile.

Expected: Profile is retrieved and displayed.
Actual: Fennec crashes (see stack trace), no profile is being retrieved.

Workaround: Removing mUniqueStacks.reset() in ThreadProfile::StreamJSON prevents the crash.
We lost one of the fixes in bug 1167230 when the standalone stuff happened
Comment on attachment 8627859 [details] [diff] [review]
Restore the std::string fix from bug 1167230

Review of attachment 8627859 [details] [diff] [review]:
-----------------------------------------------------------------

Blahhh. This is terrible :(

But thanks for doing this, not your fault!
Attachment #8627859 - Flags: review?(bgirard) → review+
Duplicate of this bug: 1178647
https://hg.mozilla.org/mozilla-central/rev/1ba35f411eee
Assignee: nobody → snorp
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Duplicate of this bug: 1154851
You need to log in before you can comment on or make changes to this bug.