1179163 - [meta] Hello visual refresh

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Comment 1

[Victoria Gerchinhoren [:vicky]]

Please, find always the latest version of common controls in the following link: https://www.dropbox.com/s/jxbiz6i7uo6bmdn/Hello_CommonEements_Sheet.png?dl=0

Comment 2

[Romain Testard [:RT]]

Hi Matej, we're implementing a visual refresh in Hello for Fx42. Are you the right person to help us confirm that all strings in our visuals are OK to go?

Here is the folder with the visual designs that are getting implemented:
https://www.dropbox.com/sh/46pyq5wwgnif6g8/AACEqjLwDw1be0oMYw-okHA9a?dl=0
This will ride the trains with Fx42.

Comment 3

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #2)
> Hi Matej, we're implementing a visual refresh in Hello for Fx42. Are you the
> right person to help us confirm that all strings in our visuals are OK to go?
> 
> Here is the folder with the visual designs that are getting implemented:
> https://www.dropbox.com/sh/46pyq5wwgnif6g8/AACEqjLwDw1be0oMYw-okHA9a?dl=0
> This will ride the trains with Fx42.

Yes, I can help. Is there somewhere I can just see the strings you need me to review?

Also, when would you need this by?

Comment 4

[Matej Novak [:matej]]

Also adding Troy and Sevaan here. Didn't we work on copy for an unsupported browser screen at some point? I don't think it matches what's in the Dropbox link in comment 2.

Comment 5

[Troy Palmer]

According to this bug —  https://bugzilla.mozilla.org/show_bug.cgi?id=1132236 — this is the final copy for the unsupported browser screen:

We were afraid this might happen
Looks like a friend has invited you to a free video conversation on Firefox Hello. Unfortunately, the browser you’re using doesn’t support the technology needed for you to connect. Join the conversation now using Firefox.
Get Firefox »

Comment 6

[Romain Testard [:RT]]

Thanks Matej and Troy!
I don't believe there is a place where all strings are besides the visual design doc I pointed to (maybe Sevaan can confirm).
It would be great to have it in time for your suggested string changes to be implemented prior to Aurora 42 uplift which happens August 10th. Please keep in mind that the link clicker site does not follow the release trains therefore it makes sense to focus on the desktop client elements first since these will have to be riding the trains. We can address the link clicker changes later if this helps.

Comment 7

[Matej Novak [:matej]]

(In reply to Romain Testard [:RT] from comment #6)
> Thanks Matej and Troy!
> I don't believe there is a place where all strings are besides the visual
> design doc I pointed to (maybe Sevaan can confirm).

Unfortunately it's really difficult to review, comment and edit strings in this format. Is there any way the copy can be pulled into a more easily editable format? As it is, I'm not even sure what's new, what's existing and what to focus on.


> Please keep
> in mind that the link clicker site does not follow the release trains
> therefore it makes sense to focus on the desktop client elements first since
> these will have to be riding the trains. We can address the link clicker
> changes later if this helps.

I'm not sure what this means. Are you saying we can't use the copy in comment 5 for the unsupported state?

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

It looks like we're missing a mockup for any intended refresh of the panel's "first time experience" flow.  Is that going to be refreshed?

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Also, is there going to be an updated visual mockup based on the font-related unit discussion we had on Tuesday?

Comment 10

[Victoria Gerchinhoren [:vicky]]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #8)
> It looks like we're missing a mockup for any intended refresh of the panel's
> "first time experience" flow.  Is that going to be refreshed?

Hey, I think this is a question for Sevaan as I don't recall seeing this specs.

Comment 11

[Romain Testard [:RT]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #10)
> (In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment
> #8)
> > It looks like we're missing a mockup for any intended refresh of the panel's
> > "first time experience" flow.  Is that going to be refreshed?
> 
> Hey, I think this is a question for Sevaan as I don't recall seeing this
> specs.
Dan and Vicky.
Yes we need this - good catch.
Vicky I attach a screenshot of the current panel shown on FTU - can you please clarify if this needs updating given the visual refresh assets (interaction won't change).

Also Dan, I created bug 1189252 about the door hangers shown on FTU. This is low priority compared to the rest of visual refresh and having discussed with Holly we could ship 42 without this amendment but it would be good to understand if this is a good first bug for new team members - if it's the case I'd love to have it done in 42.

Comment 12

[Romain Testard [:RT]]

Attachment: FTU panel

Comment 13

[Victoria Gerchinhoren [:vicky]]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #9)
> Also, is there going to be an updated visual mockup based on the
> font-related unit discussion we had on Tuesday?

I don't think I understand the question here. The unit change won't affect the mocks. The font families will be specified in the code and will range between a variety of sans serif families that shouldn't change dramatically the UI (Arial, Helvetica Neue, Lucida Sans...). Do you need any further specifications regarding font? Can you share with me the list of fonts you'll set in the CSS?

Comment 14

[Victoria Gerchinhoren [:vicky]]

(In reply to Romain Testard [:RT] from comment #11)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #10)
> > (In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment
> > #8)
> > > It looks like we're missing a mockup for any intended refresh of the panel's
> > > "first time experience" flow.  Is that going to be refreshed?
> > 
> > Hey, I think this is a question for Sevaan as I don't recall seeing this
> > specs.
> Dan and Vicky.
> Yes we need this - good catch.
> Vicky I attach a screenshot of the current panel shown on FTU - can you
> please clarify if this needs updating given the visual refresh assets
> (interaction won't change).
> 
> Also Dan, I created bug 1189252 about the door hangers shown on FTU. This is
> low priority compared to the rest of visual refresh and having discussed
> with Holly we could ship 42 without this amendment but it would be good to
> understand if this is a good first bug for new team members - if it's the
> case I'd love to have it done in 42.

Thanks for this Romain, will take a look and make a proposal for this. Leaving the need info as pointer.

Comment 15

[Victoria Gerchinhoren [:vicky]]

(In reply to Romain Testard [:RT] from comment #11)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #10)
> > (In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment
> > #8)
> > > It looks like we're missing a mockup for any intended refresh of the panel's
> > > "first time experience" flow.  Is that going to be refreshed?
> > 
> > Hey, I think this is a question for Sevaan as I don't recall seeing this
> > specs.
> Dan and Vicky.
> Yes we need this - good catch.
> Vicky I attach a screenshot of the current panel shown on FTU - can you
> please clarify if this needs updating given the visual refresh assets
> (interaction won't change).
> 
> Also Dan, I created bug 1189252 about the door hangers shown on FTU. This is
> low priority compared to the rest of visual refresh and having discussed
> with Holly we could ship 42 without this amendment but it would be good to
> understand if this is a good first bug for new team members - if it's the
> case I'd love to have it done in 42.

Yes, I will update mostly spacing as this looks a bit off. 
Leaving NI as reminder.

Comment 16

[Victoria Gerchinhoren [:vicky]]

The design for this panel has been updated and included in the Panel UI mockups main file. Also a specific bug  for this has been created:1190442

Comment 17

[Romain Testard [:RT]]

(In reply to Matej Novak [:matej] from comment #7)
> (In reply to Romain Testard [:RT] from comment #6)
> > Thanks Matej and Troy!
> > I don't believe there is a place where all strings are besides the visual
> > design doc I pointed to (maybe Sevaan can confirm).
> 
> Unfortunately it's really difficult to review, comment and edit strings in
> this format. Is there any way the copy can be pulled into a more easily
> editable format? As it is, I'm not even sure what's new, what's existing and
> what to focus on.
> 
Sevaan and Vicky can you please highlight if the visuals use a different copy from the currently used copy and where it differs to help Matej focus just on the changes that were made??
> 
> > Please keep
> > in mind that the link clicker site does not follow the release trains
> > therefore it makes sense to focus on the desktop client elements first since
> > these will have to be riding the trains. We can address the link clicker
> > changes later if this helps.
> 
> I'm not sure what this means. Are you saying we can't use the copy in
> comment 5 for the unsupported state?
The unsupported state copy appears in the link clicker UI (the Hello website) and we are testing several variations of that copy on optimizely currently to optimize the clicks on the "Download" button. Gareth is managing this at the moment.

Comment 18

[Sevaan Franks [:sevaan]]

These are the changes I can see. Vicky, am I missing any?

Empty conversation windows
Current: "Invite someone to join you." http://i.sevaan.com/image/260f2v2k3F0b
Mockup: "Invite a feiend to join you" http://i.sevaan.com/image/173Q0n0T100R


Empty room
Current: "You're the first one here." http://i.sevaan.com/image/2I3Y183l1I2e
Mockups: "This room is empty. *crickets chirping*" http://i.sevaan.com/image/1x3h1L1R3o0E


Contacts search 
Current: "Search" http://i.sevaan.com/image/0g130q0W1D1f
Mockup: "Type in contact name, email, phone number" http://i.sevaan.com/image/1P0Z0E2H052c
This could probably just be shorted to "Search contacts"


Add Contacts button
Current: "New contact" http://i.sevaan.com/image/3n0a3j0v1e1y
Mockup: "Add new contact" http://i.sevaan.com/image/323T0A1r1234


Empty Conversation List
Current: "No current conversations" http://i.sevaan.com/image/1x1Z2t0T3d2a
Mockup: "There are no conversation yet / start a new conversation!" http://i.sevaan.com/image/1G0m2l3b3L3g
I believe these strings were changed in a bug somewhere, but the changes are not in the visuals.

Comment 19

[Victoria Gerchinhoren [:vicky]]

I would add: 
"Sorry, you cannot join this conversation. Link might be expired or invalid."
https://www.dropbox.com/s/g0d3egf6sy6zwsx/Captura%20de%20pantalla%202015-08-12%20a%20las%2015.35.51.png?dl=0

"Oops, it looks like this place is busy, this conversation is full."
https://www.dropbox.com/s/lu75tw881fqxb72/Captura%20de%20pantalla%202015-08-12%20a%20las%2015.36.05.png?dl=0

Also, the chat input area placeholder can use some fun, inviting text in there, instead of "type here". If you have any better suggestion, it would be super helpful. https://www.dropbox.com/s/7nkgzyxtzguvope/Captura%20de%20pantalla%202015-08-12%20a%20las%2017.12.27.png?dl=0

Comment 20

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Romain Testard [:RT] from comment #11)
> 
> Also Dan, I created bug 1189252 about the door hangers shown on FTU. This is
> low priority compared to the rest of visual refresh and having discussed
> with Holly we could ship 42 without this amendment but it would be good to
> understand if this is a good first bug for new team members - if it's the
> case I'd love to have it done in 42.

I don't think this is a great early bug, because it's inside XUL chrome stuff.  That said, I'd be surprised if it were particularly hard.

Comment 21

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this still aimed for 42, or for 43?  It's best to try to straighten out and land all the strings this week as soon as possible before 43 moves to the aurora channel. 

Pike or flod are you aware of this project for localization? Just checking in.

Comment 22

[Francesco Lodolo [:flod]]

Hello usually pre-lands strings in mozilla-central if a new feature is going to land soon, so I don't expect surprises from them.

As far as I can tell strings are landing in other bugs. For example "New contact" -> "Add new contact" landed in bug 1195677 almost a month ago. Not completely sure how to read this bug then.

Comment 23

[Mark Banner (:standard8)]

This bug is just the tracker for all the work. It is only going to land in 43 (what did land in 42 was backed out a week or so ago). I think most of the strings have landed, but will review bugs today.

Comment 24

[Mark Banner (:standard8)]

We completed this refresh last year. Hence marking as fixed. The remaining bugs will be tracked individually.