1179849 - (Welsh-keyboard) Add a keyboard to input Welsh

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Guillaume Marty [:gmarty]]

There is currently no existing keyboard to input Welsh (language code: cy), although it is one of the languages available for the UI.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Tim, are you the right person to review this patch? If not, please redirect it. Thanks!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8628944 [details] [review]
Github PR

\o/ I assume you have tested the layout.

You would need a patch to put the dictionary on CDN as well. e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1160883

Comment 3

[Guillaume Marty [:gmarty]]

Attachment: Github PR for CDN

Hi Benson. Can you review this PR and deploy to the CDN?
Then I can merge the Gaia branch in. Many thanks!

Comment 4

[Benson Wong [:mostlygeek]]

Comment on attachment 8629310 [details] [review]
Github PR for CDN

Merged.

Comment 5

[Benson Wong [:mostlygeek]]

Merged and deployed to the CDN.

Comment 6

[Guillaume Marty [:gmarty]]

Thanks Benson!

Landed in master in https://github.com/mozilla-b2g/gaia/commit/16b0685be0ada05c84d44e61e105a8104043b275