Closed Bug 1179849 (Welsh-keyboard) Opened 7 years ago Closed 7 years ago

Add a keyboard to input Welsh

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S2 (10Jul)

People

(Reporter: gmarty, Assigned: gmarty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
58 bytes, text/x-github-pull-request
Details | Review
There is currently no existing keyboard to input Welsh (language code: cy), although it is one of the languages available for the UI.
Attached file Github PR
Tim, are you the right person to review this patch? If not, please redirect it. Thanks!
Attachment #8628944 - Flags: review?(timdream)
Assignee: nobody → gmarty
Comment on attachment 8628944 [details] [review]
Github PR

\o/ I assume you have tested the layout.

You would need a patch to put the dictionary on CDN as well. e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1160883
Attachment #8628944 - Flags: review?(timdream) → review+
Attached file Github PR for CDN
Hi Benson. Can you review this PR and deploy to the CDN?
Then I can merge the Gaia branch in. Many thanks!
Attachment #8629310 - Flags: review?(bwong)
Comment on attachment 8629310 [details] [review]
Github PR for CDN

Merged.
Attachment #8629310 - Flags: review?(bwong)
Merged and deployed to the CDN.
Thanks Benson!

Landed in master in https://github.com/mozilla-b2g/gaia/commit/16b0685be0ada05c84d44e61e105a8104043b275
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
Target Milestone: 2.0 S5 (4july) → FxOS-S2 (10Jul)
Alias: Welsh-keyboard
You need to log in before you can comment on or make changes to this bug.